On 03/20/18 21:47, Zbigniew Jędrzejewski-Szmek wrote:
On Tue, Mar 20, 2018 at 04:11:46PM +0000, Zbigniew Jędrzejewski-Szmek
wrote:
> On Tue, Mar 20, 2018 at 03:28:23PM +0100, Miro Hrončok wrote:
>> On 20.3.2018 14:45, Zbigniew Jędrzejewski-Szmek wrote:
>>> Indeed, I'm using those python packages like a dinosaur ;)
>>
>> :D
>>
>>> What about adding conditionals like
>>>
>>> %if 0%{?rhel} > 7 || 0%{?fedora} > 31
>>> # Disable python2 build by default
>>> %bcond_with python2
>>> %else
>>> %bcond_without python2
>>> %endif
>>>
>>> starting now?
>>
>> I am not against that. However currently that number (31) is
>> somewhat artificial. it's up to the maintainer to choose if it's 28
>> or 32 (or anything in between). Should we somehow recommend a
>> specific Fedora release here? Why 31?
> Re 31: my thinking was that python2-eos is at 2010-01-01. If we keep
> up current biannual release schedule, we'll have 28 and 29 this year,
> 30 and 31 in 2019, and 32 in early 2020. But this is of course wrong,
> because we need python2 support for the lifetime of the release, not
> just at the start. So actually 29 which will be supported until
> 2018-10-30 + 13 months ≈ 2020-01-01, is the last release overlapped
> by python2 support. This right conditional would be:
>
> %if 0%{?rhel} > 7 || 0%{?fedora} > 28
>
> but that round around the corner. So it's not even necessary to add
> the conditional, as long as the patch to drop support is only added
> in rawhide, not F28.
>
> OK, so I withdraw my objections. Removing python2 support in rawhide
> is fine.
Pff, sorry I can't count. The right conditional would be
%if 0%{?rhel} > 7 || 0%{?fedora} > 29
so dropping support in rawhide right now would be premature. It seems
that adding a conditional like that is the way to go for now.
Compared to just removing the subpackage, it's a difference of just one
release. It may not be worth the complication of conditionalizing
everything.
I'd say maintainers can either drop the subpackages now in Rawhide, or
add a conditional for Fedora > 29 -- up to the maintainer.