Dear all,
We are retiring python-pytest-flake8.
It FTBFS: https://bugzilla.redhat.com/show_bug.cgi?id=2226304
and abandoned upstream: https://github.com/tholo/pytest-flake8/issues/98 (some suggest using ruff instead)
and in addition, running linters in %check is discouraged anyway: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters
I did a dependency analysis a couple of days ago and only python-nashpy popped up, this was a leftover because of manually specified test dependencies since fixed in https://src.fedoraproject.org/rpms/python-nashpy/pull-request/2
And there are no more dependents.
If I miss anything in this query -- your package is FTBFS already anyway after the mass rebuild, so please remove the dependency.
``` michel in fedora/reviews/other took 13m39s ⬢ [fedora-toolbox:38] ❯ rpmdistro-repoquery fedora rawhide --enablerepo=fedora-source --whatrequires python-pytest-flake8 Fedora rawhide - x86_64 19 MB/s | 73 MB 00:03 Fedora rawhide - Source 7.2 MB/s | 8.1 MB 00:01 Fedora rawhide - x86_64 - Updates 1.2 MB/s | 1.7 MB 00:01 Last metadata expiration check: 0:00:01 ago on Thu Jul 27 11:21:52 2023.
michel in fedora/reviews/other took 37s ⬢ [fedora-toolbox:38] ❯ ```
Best regards,
On 27. 07. 23 18:26, Michel Alexandre Salim wrote:
⬢ [fedora-toolbox:38] ❯ rpmdistro-repoquery fedora rawhide --enablerepo=fedora-source --whatrequires python-pytest-flake8
Always use the actual binary package name for queries like this, as only the actual package name will show all dependencies that happen to require a differetn virtual provide:
$ repoquery -q --repo=rawhide{,-source} --whatrequires python3-pytest-flake8 cvise-0:2.4.0-3.fc36.src python-cssutils-0:2.6.0-2.fc38.src python-nashpy-0:0.0.37-1.fc39.src python-pyunicorn-0:0.6.1-12.fc38.src
Thanks Miro!
On Thu, 2023-07-27 at 19:28 +0200, Miro Hrončok wrote:
On 27. 07. 23 18:26, Michel Alexandre Salim wrote:
⬢ [fedora-toolbox:38] ❯ rpmdistro-repoquery fedora rawhide -- enablerepo=fedora-source --whatrequires python-pytest-flake8
Always use the actual binary package name for queries like this, as only the actual package name will show all dependencies that happen to require a differetn virtual provide:
$ repoquery -q --repo=rawhide{,-source} --whatrequires python3- pytest-flake8 cvise-0:2.4.0-3.fc36.src python-cssutils-0:2.6.0-2.fc38.src python-nashpy-0:0.0.37-1.fc39.src python-pyunicorn-0:0.6.1-12.fc38.src
nashpy is fixed, but I'll take a look at the others. Given the disttags they look like they FTBFSed anyway (cvise is fc36, ouch!)
I won't retire pytest-flake8 until after checking the dependents, just in case we still need to hotfix it (though my preference will be to drop it as it should never have been run)
Best,
On 27-07-2023 21:02, Michel Alexandre Salim wrote:
Thanks Miro!
On Thu, 2023-07-27 at 19:28 +0200, Miro Hrončok wrote:
On 27. 07. 23 18:26, Michel Alexandre Salim wrote:
⬢ [fedora-toolbox:38] ❯ rpmdistro-repoquery fedora rawhide -- enablerepo=fedora-source --whatrequires python-pytest-flake8
Always use the actual binary package name for queries like this, as only the actual package name will show all dependencies that happen to require a differetn virtual provide:
$ repoquery -q --repo=rawhide{,-source} --whatrequires python3- pytest-flake8 cvise-0:2.4.0-3.fc36.src python-cssutils-0:2.6.0-2.fc38.src python-nashpy-0:0.0.37-1.fc39.src python-pyunicorn-0:0.6.1-12.fc38.src
nashpy is fixed, but I'll take a look at the others. Given the disttags they look like they FTBFSed anyway (cvise is fc36, ouch!)
I can take care of pyunicorn. It looks simple enough.
-- Sandro
On 27-07-2023 22:57, Sandro wrote:
On 27-07-2023 21:02, Michel Alexandre Salim wrote:
Thanks Miro!
On Thu, 2023-07-27 at 19:28 +0200, Miro Hrončok wrote:
On 27. 07. 23 18:26, Michel Alexandre Salim wrote:
⬢ [fedora-toolbox:38] ❯ rpmdistro-repoquery fedora rawhide -- enablerepo=fedora-source --whatrequires python-pytest-flake8
Always use the actual binary package name for queries like this, as only the actual package name will show all dependencies that happen to require a differetn virtual provide:
$ repoquery -q --repo=rawhide{,-source} --whatrequires python3- pytest-flake8 cvise-0:2.4.0-3.fc36.src python-cssutils-0:2.6.0-2.fc38.src python-nashpy-0:0.0.37-1.fc39.src python-pyunicorn-0:0.6.1-12.fc38.src
nashpy is fixed, but I'll take a look at the others. Given the disttags they look like they FTBFSed anyway (cvise is fc36, ouch!)
I can take care of pyunicorn. It looks simple enough.
Consider pyunicorn fixed. The package itself is still broken, but that's numpy related not due to the removal of pytest-flake8.
-- Sandro
On Fri, Jul 28, 2023 at 12:17:54AM +0200, Sandro wrote:
On 27-07-2023 22:57, Sandro wrote:
On 27-07-2023 21:02, Michel Alexandre Salim wrote:
Thanks Miro!
On Thu, 2023-07-27 at 19:28 +0200, Miro Hrončok wrote:
On 27. 07. 23 18:26, Michel Alexandre Salim wrote:
⬢ [fedora-toolbox:38] ❯ rpmdistro-repoquery fedora rawhide -- enablerepo=fedora-source --whatrequires python-pytest-flake8
Always use the actual binary package name for queries like this, as only the actual package name will show all dependencies that happen to require a differetn virtual provide:
$ repoquery -q --repo=rawhide{,-source} --whatrequires python3- pytest-flake8 cvise-0:2.4.0-3.fc36.src python-cssutils-0:2.6.0-2.fc38.src python-nashpy-0:0.0.37-1.fc39.src python-pyunicorn-0:0.6.1-12.fc38.src
nashpy is fixed, but I'll take a look at the others. Given the disttags they look like they FTBFSed anyway (cvise is fc36, ouch!)
I can take care of pyunicorn. It looks simple enough.
Consider pyunicorn fixed. The package itself is still broken, but that's numpy related not due to the removal of pytest-flake8.
Thank you!
I'll check cvise and cssutils.
On Fri, Jul 28, 2023 at 11:39:56AM -0500, Michel Alexandre Salim wrote:
On Fri, Jul 28, 2023 at 12:17:54AM +0200, Sandro wrote:
On 27-07-2023 22:57, Sandro wrote:
On 27-07-2023 21:02, Michel Alexandre Salim wrote:
Thanks Miro!
On Thu, 2023-07-27 at 19:28 +0200, Miro Hrončok wrote:
On 27. 07. 23 18:26, Michel Alexandre Salim wrote:
⬢ [fedora-toolbox:38] ❯ rpmdistro-repoquery fedora rawhide -- enablerepo=fedora-source --whatrequires python-pytest-flake8
Always use the actual binary package name for queries like this, as only the actual package name will show all dependencies that happen to require a differetn virtual provide:
$ repoquery -q --repo=rawhide{,-source} --whatrequires python3- pytest-flake8 cvise-0:2.4.0-3.fc36.src python-cssutils-0:2.6.0-2.fc38.src python-nashpy-0:0.0.37-1.fc39.src python-pyunicorn-0:0.6.1-12.fc38.src
nashpy is fixed, but I'll take a look at the others. Given the disttags they look like they FTBFSed anyway (cvise is fc36, ouch!)
I can take care of pyunicorn. It looks simple enough.
Consider pyunicorn fixed. The package itself is still broken, but that's numpy related not due to the removal of pytest-flake8.
Thank you!
I'll check cvise and cssutils.
cvise has an open PR that fixes it (and get it to build again): https://src.fedoraproject.org/rpms/cvise/pull-request/3
python-cssutils is fixed in https://src.fedoraproject.org/rpms/python-cssutils/pull-request/2
python-pytest-flake8 is now retired. Thanks for everyone who patched the dependent packages!
Best,
python-devel@lists.fedoraproject.org
-
Michel Alexandre Salim -
Miro Hrončok -
Sandro