Review Request 46: New admin interface and builds support
by Martin Krizek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------
Review request for blockerbugs.
Repository: blockerbugs
Description
-------
Implement new admin interface with flask-admin
Add build support
Diffs
-----
testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1
testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849
testing/test_api.py 15ddd7dd03c5d3675fab78c70f2687b838d94b08
setup.py 8a55d39674daf9bd240220ed8a147a691aa23a66
sass/admin_layout.scss PRE-CREATION
requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018
blockerbugs/util/koji_interface.py PRE-CREATION
blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672
blockerbugs/templates/admin_layout.html PRE-CREATION
blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6
blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35
blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149
blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82
blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e
blockerbugs/static/js/admin.js PRE-CREATION
blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189
blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78
blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4
blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2
blockerbugs/models/build.py PRE-CREATION
blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2
blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd
blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50
blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf
blockerbugs/controllers/api/api.py 30de9189473bb8bbeb63b7578e5e21de0a51d2d7
blockerbugs/controllers/admin/spin.py PRE-CREATION
blockerbugs/controllers/admin/build.py PRE-CREATION
blockerbugs/controllers/admin/auth.py PRE-CREATION
blockerbugs/controllers/admin/__init__.py PRE-CREATION
blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a
blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186
blockerbugs/__init__.py 1bac593a334a848308fdb362deee496a046293e8
blockerbugs.spec 083c7c29789e172d48e455413478f376ef3eb099
alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION
alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
Testing
-------
I've tested on my develop instance.
Thanks,
Ilgiz Islamgulov
10 years, 7 months
Re: [Fedora QA] #357: Improve asset management
by fedora-badges
#357: Improve asset management
---------------------------------------+-----------------------
Reporter: tflink | Owner: mkrizek
Type: enhancement | Status: new
Priority: minor | Milestone: Fedora 20
Component: Blocker bug tracker page | Version:
Resolution: | Keywords:
Blocked By: | Blocking:
---------------------------------------+-----------------------
Comment (by tflink):
when I install a package built for el6 and try to run sync, I get a
traceback:
{{{
[root@blockerbugspackagetest ~]# blockerbugs sync
Traceback (most recent call last):
File "/usr/bin/blockerbugs", line 9, in <module>
load_entry_point('blockerbugs==0.3.0.5', 'console_scripts',
'blockerbugs')()
File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 299, in
load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 2229, in
load_entry_point
return ep.load()
File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 1948, in
load
entry = __import__(self.module_name, globals(),globals(),
['__name__'])
File "/usr/lib/python2.6/site-packages/blockerbugs/__init__.py", line 4,
in <module>
from flask.ext.assets import Environment
File "/usr/lib/python2.6/site-packages/flask_assets.py", line 5, in
<module>
from webassets.env import (\
ImportError: No module named webassets.env
}}}
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/357#comment:3>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
10 years, 7 months
Reviewboard Account Registration
by Tim Flink
In the last couple days, about 25 spam users have registered in our
reviewboard instance. I've already deleted the accounts before they
could do any damage but I've also disabled new user registration so the
problem doesn't continue.
I'm happy to grant new accounts to real people, though. If you'd like
an account, just let me know and hopefully we'll be able to migrate to
fas-openid auth soon.
Tim
10 years, 7 months
[Fedora QA] #390: modifying milestone through admin web interface generates http 500 errors
by fedora-badges
#390: modifying milestone through admin web interface generates http 500 errors
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: defect | Status: new
Priority: critical | Milestone: Fedora 20
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+------------------------
= bug description =
When changing a milestone through the web admin interface, saving changes
generates a http 500 error with the following traceback:
{{{
Traceback (most recent call last):
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1701, in __call__
return self.wsgi_app(environ, start_response)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1689, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1687, in wsgi_app
response = self.full_dispatch_request()
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1360, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1358, in full_dispatch_request
rv = self.dispatch_request()
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1344, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/home/tflink/code/blockerbugs/blockerbugs/controllers/users.py",
line 95, in decorated_function
return f(*args, **kwargs)
File "/home/tflink/code/blockerbugs/blockerbugs/controllers/admin.py",
line 148, in modify_milestone
milestone.succeeds = selected_succeeds
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/sqlalchemy/orm/attributes.py", line 155, in __set__
instance_dict(instance), value, None)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/sqlalchemy/orm/dynamic.py", line 117, in set
self._set_iterable(state, dict_, value)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/sqlalchemy/orm/dynamic.py", line 122, in _set_iterable
new_values = list(iterable)
TypeError: 'Milestone' object is not iterable
}}}
= fix recommendation =
Saving the milestone shouldn't tb and the save operation should complete
successfully
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/390>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
10 years, 7 months
[Fedora QA] #414: "Internal Server Error" after submitting a proposal for freeze exception
by fedora-badges
#414: "Internal Server Error" after submitting a proposal for freeze exception
--------------------------------------+---------------------
Reporter: pschindl | Owner: tflink
Type: defect | Status: new
Priority: major | Milestone:
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+---------------------
= bug description =
I submitted a proposal for freeze exception. I got "Internal server error"
after I click on 'Submit Proposal'. I tried it 3 times and it happened
every time (I opened a new tab for every proposal).
= bug analysis =
= fix recommendation =
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/414>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
10 years, 7 months
