This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/52/ |
On September 20th, 2013, 9:46 a.m. UTC, Martin Krizek wrote:
blockerbugs/controllers/main.py (Diff revision 1) def check_bz_user(user, password):334 userinfo = UserInfo(auth.user.username, fas_bz_form.bz_user.data)333 userinfo = UserInfo(g.fas_user.username, fas_bz_form.bz_user.data)This really should be merged in develop as well as it would result in a traceback when one tries to associate his fas and bugzilla accounts. I don't see it fixed anywhere.On September 24th, 2013, 3:47 p.m. UTC, Tim Flink wrote:
a lot of the auth stuff was reworked in new_admin due to an issue that ilgiz found. you can push this if it works but it'll be overwritten by changes that are due to be merged into develop soon
Ah ok, so that's where it is fixed. In general, I'd rather see issues like this one fixed in a separate hotfix branch though. Closing this.
- Martin
On September 13th, 2013, 11:08 a.m. UTC, Martin Krizek wrote:
Review request for blockerbugs.
By Martin Krizek.
Updated Sept. 13, 2013, 11:08 a.m.
Repository:
blockerbugs
Description
Diffs
|