[ClusterLabs/libqb] 5279aa: Fix detection of warning flags for clang
by David Vossel
Branch: refs/heads/master
Home: https://github.com/ClusterLabs/libqb
Commit: 5279aa3b5ffe60010f9a29a6db98ba0f4cd292c3
https://github.com/ClusterLabs/libqb/commit/5279aa3b5ffe60010f9a29a6db98b...
Author: Ruben Kerkhof <ruben(a)rubenkerkhof.com>
Date: 2015-01-19 (Mon, 19 Jan 2015)
Changed paths:
M configure.ac
Log Message:
-----------
Fix detection of warning flags for clang
Using ./configure CC=clang, the following flags are detected
as supported:
checking whether clang supports "-Wgnu89-inline"... yes
checking whether clang supports "-Wno-strict-aliasing"... yes
Which results in a lot of warnings during make:
warning: unknown warning option '-Wunsigned-char' [-Wunknown-warning-option]
warning: unknown warning option '-Wgnu89-inline' [-Wunknown-warning-option]
Clang doesn't support these flags, but the compile check returns a
warning, not an error:
configure:16649: checking whether clang supports "-Wunsigned-char"
configure:16662: clang -E -Wunsigned-char conftest.c
warning: unknown warning option '-Wunsigned-char' [-Wunknown-warning-option]
1 warning generated.
configure:16662: $? = 0
configure:16663: result: yes
Commit: fb664811105afff66f48f214d5d0b82a1e1c0bee
https://github.com/ClusterLabs/libqb/commit/fb664811105afff66f48f214d5d0b...
Author: David Vossel <dvossel(a)redhat.com>
Date: 2015-01-20 (Tue, 20 Jan 2015)
Changed paths:
M configure.ac
Log Message:
-----------
Merge pull request #137 from rubenk/detect-warning-flags-better
Fix detection of warning flags for clang
Compare: https://github.com/ClusterLabs/libqb/compare/9e8d0e6e4326...fb664811105a
9 years, 3 months
[ClusterLabs/libqb] ea4d93: Fix: Unlink files bound to unix domain sockets
by David Vossel
Branch: refs/heads/master
Home: https://github.com/ClusterLabs/libqb
Commit: ea4d93156321ad66867a63568ad82a79731e8832
https://github.com/ClusterLabs/libqb/commit/ea4d93156321ad66867a63568ad82...
Author: Andreas Grueninger <Andreas.Grueninger(a)some.where>
Date: 2014-12-22 (Mon, 22 Dec 2014)
Changed paths:
M lib/ipc_socket.c
Log Message:
-----------
Fix: Unlink files bound to unix domain sockets
In qb_ipcs_us_connect 4 files are created and bound.
I dont' know how this works for QB_LINUX or QB_CYGWIN.
But for the other OS the files are created and must be unlinked.
I use the same logic to construct the file names and unlink the files.
qb_ipcc_us_connect calls this
...
res = qb_ipc_dgram_sock_connect(r->response, "response", "request",
r->max_msg_size, &c->request.u.us.sock);
and qb_ipc_dgram_sock_connect calls
..
set_sock_addr
and in set_sock_addr the files are created if not Linux or Cygwin.
...
#if defined(QB_LINUX) || defined(QB_CYGWIN)
snprintf(address->sun_path + 1, UNIX_PATH_MAX - 1, "%s", socket_name);
#else
snprintf(address->sun_path, sizeof(address->sun_path), "%s/%s", SOCKETDIR,
socket_name);
#endif
...
Commit: 01703fdf62287ebe36df3ef2591b600c53916df7
https://github.com/ClusterLabs/libqb/commit/01703fdf62287ebe36df3ef2591b6...
Author: Andreas Grueninger <Andreas.Grueninger(a)some.where>
Date: 2015-01-13 (Tue, 13 Jan 2015)
Changed paths:
M lib/ipc_socket.c
Log Message:
-----------
Fix: Unlink files before qb_ipcc_us_sock_close
Changed the #if clauses to all non linux OSe.
Commit: 9e8d0e6e4326843de5ae1c27783e533f94434466
https://github.com/ClusterLabs/libqb/commit/9e8d0e6e4326843de5ae1c27783e5...
Author: David Vossel <dvossel(a)redhat.com>
Date: 2015-01-13 (Tue, 13 Jan 2015)
Changed paths:
M lib/ipc_socket.c
Log Message:
-----------
Merge pull request #136 from grueni/upstream4
Fix: Unlink files bound to unix domain sockets
Compare: https://github.com/ClusterLabs/libqb/compare/3f7de657855b...9e8d0e6e4326
9 years, 3 months