quarterback-devel October 2018

quarterback-devel@lists.fedorahosted.org

1 participants
3 discussions

[ClusterLabs/libqb] b38614: log: Add configure-time option to use systemd jour...

by Chrissie Caulfield

Branch: refs/heads/master Home: https://github.com/ClusterLabs/libqb Commit: b38614e5894bda4b0ce16aa9952bab12481b0fc0 https://github.com/ClusterLabs/libqb/commit/b38614e5894bda4b0ce16aa9952ba... Author: Chrissie Caulfield <ccaulfie(a)redhat.com> Date: 2018-10-26 (Fri, 26 Oct 2018) Changed paths: M configure.ac M include/qb/qblog.h M lib/Makefile.am M lib/libqb.pc.in M lib/log.c M lib/log_int.h M lib/log_syslog.c M tests/check_log.c Log Message: ----------- log: Add configure-time option to use systemd journal instead of syslog (#327) * log: add systemd journal as a logging option systemd journal can be configured as a logging option at ./configure time (--enable-systemd-journal). If libqb is buit with this then the syslog target can be switched to sending to the journal using qb_log_ctl(QB_LOG_SYSLOG, QB_LOG_CONF_USE_JOURNAL, 1); **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 6 months

1
0
0 / 0

[ClusterLabs/libqb] 6032d2: log: Add option to re-open a log file (#326)

by Chrissie Caulfield

Branch: refs/heads/master Home: https://github.com/ClusterLabs/libqb Commit: 6032d210d10710a6ae2f25de99a1ede4c9f41628 https://github.com/ClusterLabs/libqb/commit/6032d210d10710a6ae2f25de99a1e... Author: Chrissie Caulfield <ccaulfie(a)redhat.com> Date: 2018-10-16 (Tue, 16 Oct 2018) Changed paths: M include/qb/qblog.h M lib/log.c M lib/log_file.c M lib/log_int.h M lib/log_thread.c M tests/check_log.c Log Message: ----------- log: Add option to re-open a log file (#326) As this patch also brought up some locking issues with re-configuring the logging while threaded logging was enabled, it also includes locking around qb_log_ctl2() and conversion of in_logger to an atomic. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 6 months

1
0
0 / 0

[ClusterLabs/libqb] 44a937: skiplist: fix use-after-free in the skiplist trave...

by Christine Caulfield

Branch: refs/heads/master Home: https://github.com/ClusterLabs/libqb Commit: 44a9379c89e2fd0a2d09df79e2a3eaf1d1b4a5c7 https://github.com/ClusterLabs/libqb/commit/44a9379c89e2fd0a2d09df79e2a3e... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-10-15 (Mon, 15 Oct 2018) Changed paths: M lib/skiplist.c M tests/check_map.c Log Message: ----------- skiplist: fix use-after-free in the skiplist traversal (Patch from poki, only committed under my name because github is being weird) This used to happen when an iterator contained a reference on the item to continue with, which got outdated when such item had been removed in the interim, though it's original memory would still be -- mistakenly -- accessed. Actually such a condition is exercised with an existing "test_map_iter_safety(ordered=true)" test, though it likely never run under valgrind's supervision and standard memory checking harness was too coarse (perhaps because of low memory pressure or other "lucky" coincidence). Thankfully, the default, paranoid approach towards dynamic memory handling in OpenBSD (free(3) call makes small chunks "junked", i.e., filled with 0xdf bytes, see malloc.conf(5)) resulted in the explicit segmentation fault when tripping over the happens-to-be-freed pointer in the assumed iteration chain. We solve the "out-of-sync iterator" issue with a twist, inverting the responsibility to carry (and more widely, to contribute in the propagation of) the up-to-date "forward" pointers, as clearly, iterating over and over through the items would not be very scalable (and it was not done, which had resulted in the first place). So now, when any skiplist item is to be removed, its preceding item gets the "forward" pointers recomputed as before, but then, they are copied into "forward" pointers for the item to be removed, original area containing them is disposed, and this preceding item just points to the area primarily managed by the to-be-removed item (procedure dubbed "takeover-and-repoint" in the comment). This itself gets a special mark so that this area won't be dropped when that item gets disposed, which rather happens with the disposal of the preceding item that points to the "forward" memory area at hand and is not marked so. This is believed to be sufficient to address out-of-band (iterator based) access versus interim future iteration chain mangling, as these operate de facto on the non-sparse, linear level of the skiplist. Alternative approaches include: turning pointers-to-arrays into pointers-to-pointers-to-arrays to allow for explicit setting to NULL after free, and sharing this additional indirection -- this straightforward extension was attempted first, but shortly after, it became apparent it would be a nightmare with the current interprocedural dependencies extra tagging of the structures and adding complexities around checking the eligibility, like every other manipulation with the skiplist completely split life-cycle of "node" and "node->forward", i.e., separate reference-counting etc. Also said test was extended to push the corner case to the limit: when to-resume-with item in the chain is being figured out, the predecessors may be consulted (it is in that test), but the very first predecessor is now removed as well, for good measure, as it makes for boundary condition ^ 2. Signed-off-by: Jan Pokorný jpokorny(a)redhat.com **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 6 months

1
0
0 / 0

← Newer
1
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

quarterback-devel October 2018