kevin commented on the pull-request: `Fix/improve the release-candidate script.` that you are following: `` looking much better! :) Some minor comments: * What would you think about making it detect the config? right now it's hard coded (to fedora-final.conf right now). But if "Beta" appears in the label it should be fedora-beta.conf otherwise fedora-final.conf. * The dry-run / debugging '-d' is getting passed to commands, not that it matters, but minor nitpick. ie, pungi-koji --notification-script=/usr/bin/pungi-fedmsg-notification --notification-script=pungi-wait -for-signed-ostree-handler --config=fedora-final.conf --old-composes=/mnt/koji/compose/40 --skip-pha se=productimg --label=40_Beta-1.1 --target-dir=/mnt/koji/compose/40 -d (the -d at the end) * For compose id, might check that it exists and exit if not: COMPOSE_ID_2=$(cat "${TARGET_DIR}"/latest-$SHORT-"${FEDORA_VERSION}"/COMPOSE_ID) ie, check for that existing before setting it. It should if pungi finished ok, but just in case, we don't want to mess up with the syncs if something weird happened to the compose. Aside those minor things I think it might be ready. :) `` To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1223

patrikp commented on the pull-request: `Fix/improve the release-candidate script.` that you are following: `` @kevin I updated the script based on your feedback. The three things should now be fixed. CC: @jnsamyak `` To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1223