kellin opened a new pull-request against the project: `pungi-fedora` that you are following: `` automate release candidate compose rsync ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` There really is no point in checking if a hard coded variable exists or not ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` this call seems overkill ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` this is actually a label ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` why is this set? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` this is not needed ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` no need for the timestamp in here ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` These are the values we typically use, however its not a requirement that they match these values ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` there is no need for the ${PWD}/ ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` this may not be the comps file we use ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` compose_xml means what? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` this should just be removed ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` overall this PR does not meet the way we normally code, we typically use all upper case for variable names. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
kellin commented on the pull-request: `automate release candidate compose rsync` that you are following: `` It's fairly common to dump the generic help on a failure. Can remove if it's highly objectionable, but it's usually handy. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
kellin commented on the pull-request: `automate release candidate compose rsync` that you are following: `` What happens if we don't follow this convention?
This format is also used in the release-sync script to do its sanity check to ensure we're not trying to sync Alpha-1.5 into the data where Alpha-1.7 goes or the inverse.
If there are reasons to use alternate syntaxes then we should document that somewhere. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
kellin commented on the pull-request: `automate release candidate compose rsync` that you are following: `` It's not needed explicitly, but it is convention to define the full path to something. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
kellin commented on the pull-request: `automate release candidate compose rsync` that you are following: `` because later in the pushd/popd it's not readily available. This stores it for usage mid-push/pop to copy the file back. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
kellin commented on the pull-request: `automate release candidate compose rsync` that you are following: `` compose_xml would map to comps-f26.xml.
the previous version of the script appears to need manual changing each time it's run; it called it comps-f26.xml.
When would this not be the appropriate comps file and how could we differentiate between this format and the format that needs a different comps file. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
kellin commented on the pull-request: `automate release candidate compose rsync` that you are following: `` ALL_CAPS are usually reserved for the environment variables or for statically set variables to make them stand out from composed or mutable variables similar to class/member/method/variable naming standards in PEP-8. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
ausil commented on the pull-request: `automate release candidate compose rsync` that you are following: `` there is no PEP-8 standard for bash ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/209
rel-eng@lists.fedoraproject.org
-
Dennis Gilmore -
Kellin