modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/graph/graphtype/StackedBarMetricGraphImpl.java | 11 ++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
New commits: commit 6784f2a1003e5d6097bcb2c0ec7bacefb8f310f5 Author: Mike Thompson mithomps@redhat.com Date: Thu Oct 3 13:34:37 2013 -0700
Filter out very small chart selections (< 1 minute) which are most likely a user mistake with mousing around and not a valid selection.
diff --git a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/graph/graphtype/StackedBarMetricGraphImpl.java b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/graph/graphtype/StackedBarMetricGraphImpl.java index 93983e0..3bdef03 100644 --- a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/graph/graphtype/StackedBarMetricGraphImpl.java +++ b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/graph/graphtype/StackedBarMetricGraphImpl.java @@ -741,8 +741,11 @@ public class StackedBarMetricGraphImpl extends AbstractMetricGraph { var startTime = Math.round(s[0].getTime()); var endTime = Math.round(s[1].getTime() ); svg.classed("selecting", !$wnd.d3.event.target.empty()); - global.@org.rhq.enterprise.gui.coregui.client.inventory.common.graph.AbstractMetricGraph::saveDateRange(DD)(startTime, endTime); - global.@org.rhq.enterprise.gui.coregui.client.inventory.common.graph.AbstractMetricGraph::redrawGraphs()(); + // ignore selections less than 1 minute + if(endTime - startTime >= 60000){ + global.@org.rhq.enterprise.gui.coregui.client.inventory.common.graph.AbstractMetricGraph::saveDateRange(DD)(startTime, endTime); + global.@org.rhq.enterprise.gui.coregui.client.inventory.common.graph.AbstractMetricGraph::redrawGraphs()(); + } }
function updateDateRangeDisplay(startDate, endDate ) {
commit 915caea9ee047cc088496da1f6636d4df7c7ad01 Author: Mike Thompson mithomps@redhat.com Date: Thu Oct 3 10:33:16 2013 -0700
[BZ 1015205] - Chart hovers get orphaned after screen refresh. Add a timeout of 5 seconds that will automatically remove the hover at that time.
diff --git a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/graph/graphtype/StackedBarMetricGraphImpl.java b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/graph/graphtype/StackedBarMetricGraphImpl.java index df56937..93983e0 100644 --- a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/graph/graphtype/StackedBarMetricGraphImpl.java +++ b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/graph/graphtype/StackedBarMetricGraphImpl.java @@ -361,6 +361,8 @@ public class StackedBarMetricGraphImpl extends AbstractMetricGraph { //Show the tooltip $wnd.d3.select("#metricGraphTooltip").classed("hidden", false);
+ setTimeout(function(){$wnd.jQuery('#metricGraphTooltip').hide();},5000); + } function showNoDataBarHover(d){ var timeFormatter = $wnd.d3.time.format(chartContext.chartHoverTimeFormat), @@ -386,6 +388,7 @@ public class StackedBarMetricGraphImpl extends AbstractMetricGraph {
//Show the tooltip $wnd.d3.select("#noDataTooltip").classed("hidden", false); + setTimeout(function(){$wnd.jQuery('#noDataTooltip').hide();},5000);
}
@@ -551,6 +554,7 @@ public class StackedBarMetricGraphImpl extends AbstractMetricGraph {
//Show the tooltip $wnd.d3.select("#singleValueTooltip").classed("hidden", false); + setTimeout(function(){$wnd.jQuery('#singleValueTooltip').hide();},5000);
}
rhq-commits@lists.fedorahosted.org