release.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
New commits: commit 4e748fc3a39904f72832aaf758cbb2d10cc5ceff Author: Stefan Negrea snegrea@redhat.com Date: Sat Jun 22 22:02:25 2013 -0500
Update release script to make correct use of boolean flags. Boolean flags are to be used without quotes in bash scripts, adding quotes will make bash interpert them as string variables.
diff --git a/release.sh b/release.sh index 6b99187..1df6998 100755 --- a/release.sh +++ b/release.sh @@ -373,7 +373,7 @@ run_release_version_and_tag_process() fi
echo "8) Tag the current source." - if [ "$OVERRIDE_TAG" ]; + if [ $OVERRIDE_TAG ]; then git tag --force "$RELEASE_TAG" [ "$?" -ne 0 ] && abort "Force tagging failed." @@ -410,7 +410,7 @@ update_development_version() { print_function_information $FUNCNAME
- if [ "$TERMINAL_BRANCH" ]; + if [ $TERMINAL_BRANCH ]; then echo "Release branch $RELEASE_BRANCH is a terminal branch. Version on release branch no updated for future development!"; return 0; @@ -452,7 +452,7 @@ verify_tags() EXISTING_REMOTE_TAG=`git ls-remote --tags origin "$RELEASE_TAG"` if [ -n "$EXISTING_REMOTE_TAG" ]; then - if [ "$OVERRIDE_TAG" ]; + if [ $OVERRIDE_TAG ]; then echo "A remote tag named $RELEASE_TAG already exists, but will be overriden." else
rhq-commits@lists.fedorahosted.org