[rhq-project/rhq] 5fec51: Bug 1005426 - Better CLI Parsing and Error reporti...
by Thomas Segismont
Branch: refs/heads/master
Home: https://github.com/rhq-project/rhq
Commit: 5fec5167ff76c9081203b538db9098ad47765fe2
https://github.com/rhq-project/rhq/commit/5fec5167ff76c9081203b538db9098a...
Author: Thomas Segismont <tsegismo(a)redhat.com>
Date: 2014-09-29 (Mon, 29 Sep 2014)
Changed paths:
M modules/enterprise/remoting/cli/src/main/java/org/rhq/enterprise/client/ClientMain.java
M modules/enterprise/remoting/cli/src/main/java/org/rhq/enterprise/client/commands/LoginCommand.java
Log Message:
-----------
Bug 1005426 - Better CLI Parsing and Error reporting
* Unified behavior for CLI script args and "login" command args
* Fixed "login" command:
** support host definition without port definition
** output defaults for host and port
** command syntax message
** show meaningful error messages:
*** for port number format
*** for unsupported transport
*** for exceptions (use exception cause message instead of meaningless JBoss Remoting exception message)
Also, some code cleanup
9 years, 7 months
[rhq-project/rhq] c9d5d9: Bug 1122444 - Server responds with 204 even if it ...
by Libor Zoubek
Branch: refs/heads/master
Home: https://github.com/rhq-project/rhq
Commit: c9d5d91254a6032f9cb2c9f427c6f9d1b7f361ce
https://github.com/rhq-project/rhq/commit/c9d5d91254a6032f9cb2c9f427c6f9d...
Author: Libor Zoubek <lzoubek(a)redhat.com>
Date: 2014-09-29 (Mon, 29 Sep 2014)
Changed paths:
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/rest/MetricHandlerBean.java
M modules/integration-tests/rest-api/src/test/java/org/rhq/modules/integrationTests/restApi/MetricsTest.java
Log Message:
-----------
Bug 1122444 - Server responds with 204 even if it fails to find the schedule
upon POST /metric/data/raw request
As POST /metric/data/raw accepts data points for various schedule IDs
rejecting all data, just because several have invalid scheduleId may not be
a good idea. Current fix does:
* return 204 (No content) in case all scheduleIds are valid and all data
were accepted
* returns 201 (rejected data) in case some data points were rejected and
some accepted
* returns 403 (rejected data) in case all data points were rejected
This commit also fixes endpoint POST /metric/data/raw/{resourceId} which now
returns 403 in case there is at least 1 non-existing metric for given
resource ID (this case was previously failing on NPE)
Commit: 29186360a4103ad82a86dcc2b257f354c2bf7b1b
https://github.com/rhq-project/rhq/commit/29186360a4103ad82a86dcc2b257f35...
Author: Libor Zoubek <lzoubek(a)redhat.com>
Date: 2014-09-29 (Mon, 29 Sep 2014)
Changed paths:
M modules/common/jboss-as-dmr-client/src/main/java/org/rhq/common/jbossas/client/controller/InfinispanJBossASClient.java
M modules/enterprise/server/installer/src/main/java/org/rhq/enterprise/server/installer/ServerInstallUtil.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/rest/AbstractRestBean.java
Log Message:
-----------
Bug 1122444 - Server responds with 204 even if it fails to find the schedule
Get ISPN cache to work correctly for REST:
REST api was using incorrect cache name - so used cache was not
preconfigured at all, thatswhy cache entries never expired. Now, we'll
deploy rhqRestCache which is preconfigured with lifespan=15m and
max-idle=5min. This means, cache entry will be dropped and refreshed every
15minutes no matter how often is accessed and also if not accessed for
longer than 5minutes.
Commit: 39f45463d9c17aaef108dcc177898d0bd5319335
https://github.com/rhq-project/rhq/commit/39f45463d9c17aaef108dcc177898d0...
Author: Libor Zoubek <lzoubek(a)jezzovo.net>
Date: 2014-09-29 (Mon, 29 Sep 2014)
Changed paths:
M modules/common/jboss-as-dmr-client/src/main/java/org/rhq/common/jbossas/client/controller/InfinispanJBossASClient.java
M modules/enterprise/server/installer/src/main/java/org/rhq/enterprise/server/installer/ServerInstallUtil.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/rest/AbstractRestBean.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/rest/MetricHandlerBean.java
M modules/integration-tests/rest-api/src/test/java/org/rhq/modules/integrationTests/restApi/MetricsTest.java
Log Message:
-----------
Merge pull request #104 from lzoubek/bugs/1122444
Bug 1122444 - Server responds with 204 even if it fails to find the sche...
Compare: https://github.com/rhq-project/rhq/compare/b4b0238a2351...39f45463d9c1
9 years, 7 months
[rhq-project/rhq] b4b023: Bug 1146583 - "Ignore" button is disabled always u...
by Libor Zoubek
Branch: refs/heads/master
Home: https://github.com/rhq-project/rhq
Commit: b4b0238a2351928e4613e98309192ea3fe3a4eb3
https://github.com/rhq-project/rhq/commit/b4b0238a2351928e4613e98309192ea...
Author: Libor Zoubek <lzoubek(a)redhat.com>
Date: 2014-09-29 (Mon, 29 Sep 2014)
Changed paths:
M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/inventory/resource/discovery/ResourceAutodiscoveryView.java
Log Message:
-----------
Bug 1146583 - "Ignore" button is disabled always under "Discovery Queue"
Previous logic of enabling/disabling "Ignore" button tried to prevent
situation, that user could ignore a NEW platform and/or it's child. Previous
logic would not work in case user also selected at least another resource
that "could" be ignored (a child of imported platform).
Now user can ignore MEW platform as well or it's child. If platform is
IGNORED it's not possible (at least from UI) to import it's NEW children.
9 years, 7 months
[rhq-project/rhq] 160483: Bug 1146611 - Cannot discover EAP6.0.1: supportsMa...
by Thomas Segismont
Branch: refs/heads/rc/jon3.3.0.ER04
Home: https://github.com/rhq-project/rhq
Commit: 160483d00f7f17d8da1f57b0823f2ab64818a2c4
https://github.com/rhq-project/rhq/commit/160483d00f7f17d8da1f57b0823f2ab...
Author: Thomas Segismont <tsegismo(a)redhat.com>
Date: 2014-09-29 (Mon, 29 Sep 2014)
Changed paths:
M modules/core/domain/src/main/java/org/rhq/core/domain/util/OSGiVersion.java
A modules/core/domain/src/test/java/org/rhq/core/domain/util/OSGiVersionTest.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/BaseProcessDiscovery.java
Log Message:
-----------
Bug 1146611 - Cannot discover EAP6.0.1: supportsMatching method fails with IllegalArgumentException
EAP 6.1.0 version.txt file content is: "JBoss Enterprise Application Platform - Version 6.0.1 GA"
As a consequence, the version detected will be "6.0.1 GA" (notice the space instead of a dot)
Give such version strings a chance to make a valid OSGiVersion instance (avoid IllegalArgumentException)
If the version is still not matching the expected pattern, then supportsPatching default to false
Also:
* some perf improvements:
** use already compiled PATTERN instead of recompiling on each call of String#split or String.replaceAll
** use some OSGiVersion constants to avoid parsing over and over again
* some code cleanup (no longer use deprecated methods, remove unused param in private method, unchecked warning)
(cherry picked from commit 640a88cb2f126d583e46fc6b5a24f075df8d7535)
9 years, 7 months
[rhq-project/rhq] 702e61: Bug 1146611 - Cannot discover EAP6.0.1: supportsMa...
by Thomas Segismont
Branch: refs/heads/release/jon3.3.x
Home: https://github.com/rhq-project/rhq
Commit: 702e61b7e25d290f9dd8f5e523c9ba439b455615
https://github.com/rhq-project/rhq/commit/702e61b7e25d290f9dd8f5e523c9ba4...
Author: Thomas Segismont <tsegismo(a)redhat.com>
Date: 2014-09-29 (Mon, 29 Sep 2014)
Changed paths:
M modules/core/domain/src/main/java/org/rhq/core/domain/util/OSGiVersion.java
A modules/core/domain/src/test/java/org/rhq/core/domain/util/OSGiVersionTest.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/BaseProcessDiscovery.java
Log Message:
-----------
Bug 1146611 - Cannot discover EAP6.0.1: supportsMatching method fails with IllegalArgumentException
EAP 6.1.0 version.txt file content is: "JBoss Enterprise Application Platform - Version 6.0.1 GA"
As a consequence, the version detected will be "6.0.1 GA" (notice the space instead of a dot)
Give such version strings a chance to make a valid OSGiVersion instance (avoid IllegalArgumentException)
If the version is still not matching the expected pattern, then supportsPatching default to false
Also:
* some perf improvements:
** use already compiled PATTERN instead of recompiling on each call of String#split or String.replaceAll
** use some OSGiVersion constants to avoid parsing over and over again
* some code cleanup (no longer use deprecated methods, remove unused param in private method, unchecked warning)
(cherry picked from commit 640a88cb2f126d583e46fc6b5a24f075df8d7535)
9 years, 7 months
