[rhq-project/rhq] 325109: Bug 1077744 - statement timeout during drift purge...
by Thomas Segismont
Branch: refs/heads/master
Home: https://github.com/rhq-project/rhq
Commit: 3251090d63f58f0da3d604f30cc8f819533e0fcc
https://github.com/rhq-project/rhq/commit/3251090d63f58f0da3d604f30cc8f81...
Author: Thomas Segismont <tsegismo(a)redhat.com>
Date: 2014-09-25 (Thu, 25 Sep 2014)
Changed paths:
M modules/core/domain/src/main/java/org/rhq/core/domain/drift/JPADriftFile.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/drift/JPADriftServerBean.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/drift/JPADriftServerLocal.java
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/purge/JPADriftFilePurge.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/purge/PurgeManagerBean.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/purge/PurgeManagerLocal.java
M modules/enterprise/server/plugins/drift-rhq/src/main/java/org/rhq/enterprise/server/plugins/drift/JPADriftServerPluginComponent.java
Log Message:
-----------
Bug 1077744 - statement timeout during drift purge job
Changed the query WHERE clause: don't use NOT IN because NOT IN(NULL) will always return false.
See http://stackoverflow.com/questions/17150208/sql-query-with-not-in-returni...
In other words, if any row in RHQ_DRIFT as a NULL value in OLD_DRIFT_FILE or NEW_DRIFT_FILE columns, we'll never purge anything.
Besides, the NOT EXISTS variant has a better execution plan.
Use PurgeTemplate to delete rows in batches and select the keys of the rows to delete without locking the drift files table.
Also, some code cleanup.
9 years, 8 months
[rhq-project/rhq] bd1095: Bug 1125423 - Fuse Fabric Groups Plugin cannot be ...
by Libor Zoubek
Branch: refs/heads/master
Home: https://github.com/rhq-project/rhq
Commit: bd1095fa5ac2f55544d5f8c4b45033b4050b94d9
https://github.com/rhq-project/rhq/commit/bd1095fa5ac2f55544d5f8c4b45033b...
Author: Libor Zoubek <lzoubek(a)redhat.com>
Date: 2014-09-25 (Thu, 25 Sep 2014)
Changed paths:
A modules/core/domain/src/main/java/org/rhq/core/domain/plugin/PluginConfigurationRequiredException.java
M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/server/gwt/PluginGWTServiceImpl.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/plugin/ServerPluginManagerBean.java
Log Message:
-----------
Bug 1125423 - Fuse Fabric Groups Plugin cannot be enabled
Generally when there is an attempt to enable server plugins we now first
check it's configuration by looking for required properties (in ConfigDef)
and making sure there's valid value in configuration. If something is
missing, it means plugin is not configured and cannot be enabled.
ServerPluginManagerBean thows this using
PluginConfigurationRequiredException that is then presented to user.
9 years, 8 months
[rhq-project/rhq] 5be9fd: [BZ 1114199] fix handling of late data
by John Sanda
Branch: refs/heads/master
Home: https://github.com/rhq-project/rhq
Commit: 5be9fdb14de45462c8192bf1753d9ac0940c2a6c
https://github.com/rhq-project/rhq/commit/5be9fdb14de45462c8192bf1753d9ac...
Author: John Sanda <jsanda(a)redhat.com>
Date: 2014-09-24 (Wed, 24 Sep 2014)
Changed paths:
M modules/enterprise/server/server-metrics/src/main/java/org/rhq/server/metrics/MetricsServer.java
M modules/enterprise/server/server-metrics/src/main/java/org/rhq/server/metrics/aggregation/AggregationManager.java
M modules/enterprise/server/server-metrics/src/main/java/org/rhq/server/metrics/aggregation/DataAggregator.java
M modules/enterprise/server/server-metrics/src/main/java/org/rhq/server/metrics/aggregation/IndexIterator.java
M modules/plugins/rhq-server/src/main/resources/META-INF/rhq-plugin.xml
Log Message:
-----------
[BZ 1114199] fix handling of late data
My previous commits that involved setting the column timestamp on inserts had
to be reverted. When aggregating late data, it is possible to end up with a
clock tie (See https://wiki.apache.org/cassandra/FAQ#clocktie for details). In
those situations the columns might not get overwritten.
The key thing is to ensure that we do not try to recompute aggregate metrics
when some or all of the source data has already expired, leading to new,
incorrect data. I have put changes in place that should prevent this from
happening.
This commit also includes a change to IndexIterator. It will now continue
loading pages if there is a read timeout. Previously, the exception would go
uncaught causing data aggregation to abort early.
9 years, 8 months
[rhq-project/rhq] 96481d: Bug 1139684 - eap cli script does not get correct ...
by Thomas Segismont
Branch: refs/heads/release/jon3.3.x
Home: https://github.com/rhq-project/rhq
Commit: 96481d79219356f4083656d0c496fc42081533ae
https://github.com/rhq-project/rhq/commit/96481d79219356f4083656d0c496fc4...
Author: Thomas Segismont <tsegismo(a)redhat.com>
Date: 2014-09-24 (Wed, 24 Sep 2014)
Changed paths:
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/BaseServerComponent.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/ServerControl.java
A modules/plugins/jboss-as-7/src/main/resources/jboss-cli-wrapper.bat
Log Message:
-----------
Bug 1139684 - eap cli script does not get correct result code for eap domain server on windows
This is due to "WFLY-3578 jboss-cli.bat always exits with return code 0 even after a cli failure"
https://issues.jboss.org/browse/WFLY-3578
Added jboss-cli-wrapper.bat
Calling "cmd /c jboss-cli.bat" will always return 0 even if an error occurs in the CLI
Calling it through the wrapper solves the issue
Side work:
* fix standalone and domain startup: start script prefix, if set, was not added
* when an error occurs, execute command and execute script operations now copy process output into the operation result instead of the error message
* some code cleanup (avoid possible NPE)
(cherry picked from commit 62b5a80761270d3b8a16e2899383d890feeca272)
Signed-off-by: Jay Shaughnessy <jshaughn(a)redhat.com>
9 years, 8 months
[rhq-project/rhq] c1712f: Revert "[BZ 1114199] do not update insert statemen...
by John Sanda
Branch: refs/heads/master
Home: https://github.com/rhq-project/rhq
Commit: c1712f7bd6bcb839de80e8f62a60b88ce621b150
https://github.com/rhq-project/rhq/commit/c1712f7bd6bcb839de80e8f62a60b88...
Author: John Sanda <jsanda(a)redhat.com>
Date: 2014-09-24 (Wed, 24 Sep 2014)
Changed paths:
M modules/enterprise/server/server-metrics/src/main/java/org/rhq/server/metrics/InsertStatements.java
M modules/enterprise/server/server-metrics/src/main/java/org/rhq/server/metrics/MetricsServer.java
M modules/enterprise/server/server-metrics/src/test/java/org/rhq/server/metrics/InsertStatementsTest.java
Log Message:
-----------
Revert "[BZ 1114199] do not update insert statement caches more than once in a day"
This reverts commit 47d9a23404e4b57b971546052f231ec188694225.
Commit: 614b6c78b116f8de2594343f3f6b96ae65c2f15a
https://github.com/rhq-project/rhq/commit/614b6c78b116f8de2594343f3f6b96a...
Author: John Sanda <jsanda(a)redhat.com>
Date: 2014-09-24 (Wed, 24 Sep 2014)
Changed paths:
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/core/StartupBean.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/StorageClientManager.java
R modules/enterprise/server/server-metrics/src/main/java/org/rhq/server/metrics/InsertStatements.java
M modules/enterprise/server/server-metrics/src/main/java/org/rhq/server/metrics/MetricsDAO.java
M modules/enterprise/server/server-metrics/src/main/java/org/rhq/server/metrics/MetricsServer.java
M modules/enterprise/server/server-metrics/src/main/java/org/rhq/server/metrics/invalid/InvalidMetricsManager.java
M modules/enterprise/server/server-metrics/src/test/java/org/rhq/server/metrics/CassandraIntegrationTest.java
R modules/enterprise/server/server-metrics/src/test/java/org/rhq/server/metrics/InsertStatementsTest.java
M modules/enterprise/server/server-metrics/src/test/java/org/rhq/server/metrics/MetricsDAOTest.java
M modules/enterprise/server/server-metrics/src/test/java/org/rhq/server/metrics/MetricsServerTest.java
M modules/enterprise/server/server-metrics/src/test/java/org/rhq/server/metrics/MetricsTest.java
M modules/enterprise/server/server-metrics/src/test/java/org/rhq/server/metrics/invalid/InvalidMetricsManagerTest.java
Log Message:
-----------
Revert "[BZ 1114199] Make sure data expiration is consistent for late data"
This reverts commit ba64f2134a51b7e0cbd445032da95d7381b590ce.
Compare: https://github.com/rhq-project/rhq/compare/2c44cde5c500...614b6c78b116
9 years, 8 months
[rhq-project/rhq] 5db1c8: Bug 1141839 - EAP6 resource stays UP in resource t...
by Thomas Segismont
Branch: refs/heads/release/jon3.3.x
Home: https://github.com/rhq-project/rhq
Commit: 5db1c8c426c9c28643786bc7c03f28c793cad398
https://github.com/rhq-project/rhq/commit/5db1c8c426c9c28643786bc7c03f28c...
Author: Thomas Segismont <tsegismo(a)redhat.com>
Date: 2014-09-24 (Wed, 24 Sep 2014)
Changed paths:
A modules/plugins/jboss-as-7/intentional-api-changes-since-4.12.0.xml
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/BaseServerComponent.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/HostControllerComponent.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/StandaloneASComponent.java
Log Message:
-----------
Bug 1141839 - EAP6 resource stays UP in resource tree after its configuration directory was moved
Now validate configDir (not only baseDir) when resource component is started or avail goes UP
(cherry picked from commit c031e59471dbab91502eb37eeb53861014ea9daf)
Signed-off-by: Jay Shaughnessy <jshaughn(a)redhat.com>
9 years, 8 months
[rhq-project/rhq] 3ed7ce: Bug 1145195 - Bundle destination view: deployments...
by Thomas Segismont
Branch: refs/heads/release/jon3.3.x
Home: https://github.com/rhq-project/rhq
Commit: 3ed7ce007ad34d45c44c0a544f17ff0477fda6cb
https://github.com/rhq-project/rhq/commit/3ed7ce007ad34d45c44c0a544f17ff0...
Author: Thomas Segismont <tsegismo(a)redhat.com>
Date: 2014-09-24 (Wed, 24 Sep 2014)
Changed paths:
M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/bundle/destination/BundleDestinationView.java
Log Message:
-----------
Bug 1145195 - Bundle destination view: deployments table shows partial results and purge button is disabled even if there is a live deployment
This would happen when a destination has more than 200 deployments.
Now #checkIfDisabled method does not load all deployments for destination but only one live deployment if it exists.
Side work:
* removed call to deprecated method
(cherry picked from commit b8764388e55def65d9bb2dba62c7830ad4783bfa)
Signed-off-by: Jay Shaughnessy <jshaughn(a)redhat.com>
9 years, 8 months