Branch: refs/heads/jshaughn/alertdef Home: https://github.com/rhq-project/rhq Commit: 7bd758515226b6569e97729eddef84a97a09b799 https://github.com/rhq-project/rhq/commit/7bd758515226b6569e97729eddef84a97a... Author: Jay Shaughnessy jshaughn@redhat.com Date: 2014-06-17 (Tue, 17 Jun 2014)
Changed paths: M modules/core/domain/src/main/java/org/rhq/core/domain/alert/AlertDefinition.java M modules/core/domain/src/main/java/org/rhq/core/domain/criteria/AlertDefinitionCriteria.java M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/alert/definitions/GroupAlertDefinitionsView.java M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/alert/definitions/TemplateAlertDefinitionsView.java M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/gwt/AlertTemplateGWTService.java M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/gwt/GroupAlertDefinitionGWTService.java M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/server/gwt/AlertTemplateGWTServiceImpl.java M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/server/gwt/GroupAlertDefinitionGWTServiceImpl.java M modules/enterprise/server/itests-2/src/test/java/org/rhq/enterprise/server/alert/GroupAlertDefinitionManagerBeanTest.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/alert/AlertDefinitionManagerBean.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/alert/AlertDefinitionManagerLocal.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/alert/AlertDefinitionManagerRemote.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/alert/AlertTemplateManagerBean.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/alert/AlertTemplateManagerLocal.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/alert/GroupAlertDefinitionManagerBean.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/alert/GroupAlertDefinitionManagerLocal.java
Log Message: ----------- [1110434] Remote AlertDefinitionManager API does not handle template or group level definitions correctly - Repair the AlertDefinitionManagerRemote API such that enable/disable/remove methods operate on any combination of template,group or resource level alert definitions. - Properly jdoc the remote API methods, and improve some locals jdoc as well - Improve the transactioning to avoid a single umbrella transaction when invoking the API on multiple group and/or template alert definitions. - Convert GUI to use the enhanced remote API methods to benefit from the transactioning improvments and to shrink the generated Async API. - Improve i-test to use remote api and ensure child, resource-level alert defs are being handled properly.
Also: - fix a problem with authz on alert template viewing. It should not require MANAGE_SETTINGS to view alert defs via getAlertDefinitionById(). - fix a long-standing bug where child alert-defs of templates or groups were not properly detached at remove-time of the parent, which could cause GUI failures when visiting the resource-level alert definitions. - remove some unused named queries from AlertDefinition