modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/resource/detail/configuration/ResourceConfigurationEditView.java
| 27 ++++++----
1 file changed, 17 insertions(+), 10 deletions(-)
New commits:
commit 67fe9f776ddf21fcb2ee70f98fc345e184b15e43
Author: Ian Springer <ian.springer(a)redhat.com>
Date: Tue Mar 1 13:46:11 2011 -0500
hide button bar (i.e. Save button) on resource config edit view until the resource
config has been successfully loaded (
https://bugzilla.redhat.com/show_bug.cgi?id=561063)
diff --git
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/resource/detail/configuration/ResourceConfigurationEditView.java
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/resource/detail/configuration/ResourceConfigurationEditView.java
index 6f207ba..e3d6d50 100644
---
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/resource/detail/configuration/ResourceConfigurationEditView.java
+++
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/resource/detail/configuration/ResourceConfigurationEditView.java
@@ -1,6 +1,6 @@
/*
* RHQ Management Platform
- * Copyright (C) 2005-2010 Red Hat, Inc.
+ * Copyright (C) 2005-2011 Red Hat, Inc.
* All rights reserved.
*
* This program is free software; you can redistribute it and/or modify
@@ -62,10 +62,12 @@ public class ResourceConfigurationEditView extends LocatableVLayout
implements P
private Resource resource;
private ResourcePermission resourcePermission;
private ConfigurationEditor editor;
+ private ToolStrip buttonbar;
private IButton saveButton;
private boolean refreshing = false;
+
public ResourceConfigurationEditView(String locatorId, ResourceComposite
resourceComposite) {
super(locatorId);
@@ -77,11 +79,11 @@ public class ResourceConfigurationEditView extends LocatableVLayout
implements P
protected void onDraw() {
super.onDraw();
- ToolStrip toolStrip = new ToolStrip();
- toolStrip.setWidth100();
- toolStrip.setExtraSpace(10);
- toolStrip.setMembersMargin(5);
- toolStrip.setLayoutMargin(5);
+ this.buttonbar = new ToolStrip();
+ buttonbar.setWidth100();
+ buttonbar.setExtraSpace(10);
+ buttonbar.setMembersMargin(5);
+ buttonbar.setLayoutMargin(5);
this.saveButton = new LocatableIButton(this.extendLocatorId("Save"),
MSG.common_button_save());
this.saveButton.addClickHandler(new ClickHandler() {
@@ -89,9 +91,11 @@ public class ResourceConfigurationEditView extends LocatableVLayout
implements P
save();
}
});
- toolStrip.addMember(saveButton);
+ buttonbar.addMember(saveButton);
+ // The button bar will remain hidden until the configuration has been
successfully loaded.
+ buttonbar.setVisible(false);
+ addMember(buttonbar);
- addMember(toolStrip);
refresh();
if (!this.resourcePermission.isConfigureWrite()) {
@@ -108,7 +112,7 @@ public class ResourceConfigurationEditView extends LocatableVLayout
implements P
}
this.refreshing = true;
- this.saveButton.disable();
+ this.buttonbar.setVisible(false);
GWTServiceLookup.getConfigurationService().getLatestResourceConfigurationUpdate(resource.getId(),
new AsyncCallback<ResourceConfigurationUpdate>() {
@@ -129,6 +133,9 @@ public class ResourceConfigurationEditView extends LocatableVLayout
implements P
editor.addPropertyValueChangeListener(ResourceConfigurationEditView.this);
editor.setReadOnly(!resourcePermission.isConfigureWrite());
addMember(editor);
+
+ saveButton.disable();
+ buttonbar.setVisible(true);
markForRedraw();
refreshing = false;
}
@@ -138,7 +145,7 @@ public class ResourceConfigurationEditView extends LocatableVLayout
implements P
@Override
public void onFailure(Throwable caught) {
refreshing = false;
- CoreGUI.getErrorHandler().handleError("Cannot load resource
config", caught);
+ CoreGUI.getErrorHandler().handleError("Failed to load
configuration.", caught);
}
});
}