modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/components/configuration/ConfigurationEditor.java
| 12 ++++++++++
1 file changed, 12 insertions(+)
New commits:
commit 251a17e5a6f972a57c53431b02b6f16867cf463c
Author: Ian Springer <ian.springer(a)redhat.com>
Date: Thu Jun 21 17:46:45 2012 -0400
[BZ 834434] add tooltips to STRING and LONG_STRING simple props that show full
property values (
https://bugzilla.redhat.com/show_bug.cgi?id=834434)
diff --git
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/components/configuration/ConfigurationEditor.java
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/components/configuration/ConfigurationEditor.java
index 5748811..dc32e91 100644
---
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/components/configuration/ConfigurationEditor.java
+++
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/components/configuration/ConfigurationEditor.java
@@ -1401,6 +1401,8 @@ public class ConfigurationEditor extends LocatableVLayout {
}
valueItem.setValue(value);
+ setValueAsTooltipIfAppropriate(valueItem, value);
+
valueItem.setRequired(propertyDefinitionSimple.isRequired());
valueItem.setWidth(220);
@@ -1419,6 +1421,13 @@ public class ConfigurationEditor extends LocatableVLayout {
return valueItem;
}
+ private void setValueAsTooltipIfAppropriate(FormItem formItem, String value) {
+ if (((formItem instanceof TextItem) && !(formItem instanceof
PasswordItem)) ||
+ (formItem instanceof TextAreaItem)) {
+ formItem.setTooltip(value);
+ }
+ }
+
protected boolean shouldFireEventOnPropertyValueChange(FormItem formItem,
PropertyDefinitionSimple propertyDefinitionSimple, PropertySimple propertySimple)
{
PropertyMap parentMap = propertySimple.getParentMap();
@@ -1429,6 +1438,9 @@ public class ConfigurationEditor extends LocatableVLayout {
PropertyDefinitionSimple propertyDefinitionSimple) {
propertySimple.setErrorMessage(null);
propertySimple.setValue(value);
+
+ String stringValue = (value != null) ? value.toString() : null;
+ setValueAsTooltipIfAppropriate(formItem, stringValue);
}
protected static PropertyDefinition getTopLevelPropertyDefinition(PropertyDefinition
propertyDefinition) {