modules/plugins/jboss-as-5/src/main/resources/META-INF/rhq-plugin.xml | 14 ++-------- 1 file changed, 4 insertions(+), 10 deletions(-)
New commits: commit c529259817ecef5c4741f943c02e9734856dcba3 Author: Jay Shaughnessy jshaughn@redhat.com Date: Mon Jan 16 13:45:09 2012 -0500
[Bug 758503 - Various AS-5 plugin types have unset read-only plugin config props] required/read-only contextPath and filename props were not being set [reliably] at discovery time. Removed filename props, which did not seem to be used by the plugin. Set contextPath props to required="false". The value does not seem to be used by the plugin but the property is at least defined in the code.
diff --git a/modules/plugins/jboss-as-5/src/main/resources/META-INF/rhq-plugin.xml b/modules/plugins/jboss-as-5/src/main/resources/META-INF/rhq-plugin.xml index 2729d31..bac3e20 100644 --- a/modules/plugins/jboss-as-5/src/main/resources/META-INF/rhq-plugin.xml +++ b/modules/plugins/jboss-as-5/src/main/resources/META-INF/rhq-plugin.xml @@ -2278,7 +2278,6 @@ <plugin-configuration> <c:group name="general" displayName="General"> <c:simple-property name="deploymentName" description="The name of this EAR" readOnly="true"/> - <c:simple-property name="filename" readOnly="true"/> </c:group> <c:group name="advanced" displayName="Advanced" hiddenByDefault="true"> <c:simple-property name="extension" default="ear" readOnly="true"/> @@ -2335,8 +2334,8 @@ <plugin-configuration> <c:group name="general" displayName="General"> <c:simple-property name="deploymentName" description="the name of this WAR" readOnly="true"/> - <c:simple-property name="filename" readOnly="true"/> - <c:simple-property name="contextPath" description="this WAR's context path (e.g. /admin-console)" readOnly="true"/> + <!-- setting to required=false since this is not usually set properly at discovery time --> + <c:simple-property name="contextPath" description="this WAR's context path (e.g. /admin-console)" required="false" readOnly="false"/> </c:group> <c:group name="advanced" displayName="Advanced" hiddenByDefault="true"> <c:simple-property name="extension" default="war" readOnly="true"/> @@ -2418,7 +2417,8 @@ <plugin-configuration> <c:group name="general" displayName="General"> <c:simple-property name="deploymentName" description="the name of this WAR" readOnly="true"/> - <c:simple-property name="contextPath" description="this WAR's context path (e.g. /admin-console" readOnly="true"/> + <!-- setting to required=false since this is not usually set properly at discovery time --> + <c:simple-property name="contextPath" description="this WAR's context path (e.g. /admin-console" required="false" readOnly="false"/> </c:group> <c:group name="ResponseTime"> <c:simple-property name="responseTimeLogFile" required="false" @@ -2485,7 +2485,6 @@ <plugin-configuration> <c:group name="general" displayName="General"> <c:simple-property name="deploymentName" description="the name of this EJB JAR" readOnly="true"/> - <c:simple-property name="filename" readOnly="true"/> </c:group> <c:group name="advanced" displayName="Advanced" hiddenByDefault="true"> <c:simple-property name="extension" default="jar" readOnly="true"/> @@ -2581,7 +2580,6 @@ <plugin-configuration> <c:group name="general" displayName="General"> <c:simple-property name="deploymentName" description="the name of this EJB JAR" readOnly="true"/> - <c:simple-property name="filename" readOnly="true"/> </c:group> <c:group name="advanced" displayName="Advanced" hiddenByDefault="true"> <c:simple-property name="extension" default="jar" readOnly="true"/> @@ -2654,7 +2652,6 @@ <plugin-configuration> <c:group name="general" displayName="General"> <c:simple-property name="deploymentName" description="the name of this EJB JAR" readOnly="true"/> - <c:simple-property name="filename" readOnly="true"/> </c:group> <c:group name="advanced" displayName="Advanced" hiddenByDefault="true"> <c:simple-property name="extension" default="jar" readOnly="true"/> @@ -2731,7 +2728,6 @@ <plugin-configuration> <c:group name="general" displayName="General"> <c:simple-property name="deploymentName" description="the name of this EJB JAR" readOnly="true"/> - <c:simple-property name="filename" readOnly="true"/> </c:group> <c:group name="advanced" displayName="Advanced" hiddenByDefault="true"> <c:simple-property name="extension" default="jar" readOnly="true"/> @@ -2793,7 +2789,6 @@ <plugin-configuration> <c:group name="general" displayName="General"> <c:simple-property name="deploymentName" description="the name of this RAR" readOnly="true"/> - <c:simple-property name="filename" readOnly="true"/> </c:group> <c:group name="advanced" displayName="Advanced" hiddenByDefault="true"> <c:simple-property name="extension" default="rar" readOnly="true"/> @@ -2839,7 +2834,6 @@ <plugin-configuration> <c:group name="general" displayName="General"> <c:simple-property name="deploymentName" description="the name of this RAR" readOnly="true"/> - <c:simple-property name="filename" readOnly="true"/> </c:group> <c:group name="advanced" displayName="Advanced" hiddenByDefault="true"> <c:simple-property name="extension" default="rar" readOnly="true"/>
rhq-commits@lists.fedorahosted.org