Review Request 69: RoleBase: Implement installFirewall, updateFirewall and uninstallFirewall
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/69/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
installFirewall uses the firewall _settings from the role: firewall and firewall_zones and stores the applied settings in _settings per zone and also for the runtime and permanant firewalld environment.
uninstallFirewall uses the fw_changes _setting from the role and removed them from the zones in runtime and permanent firewalld environment, then clears fw_changes and savet it to _settings again.
updateFirewall calls uninstallFirewall and then installFirewall
_check_property now checks ports to be valid.
Diffs
-----
src/rolekit/server/rolebase.py 783804e3f8529232b1c0327de4d87130aaca119d
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/69/diff/
Testing
-------
Thanks,
Thomas Woerner
9 years, 6 months
Review Request 63: Domain Controller deployment
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/63/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
Repository: rolekit
Description
-------
Domain Controller deployment
Diffs
-----
config/roles/domaincontroller/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/63/diff/
Testing
-------
Performed a mostly-successful deployment of FreeIPA onto a Fedora 21 VM.
(Mostly-successful because there appears to be an ipa-server-install bug preventing successful completion, but that should be irrelevant to this patch).
Thanks,
Stephen Gallagher
9 years, 7 months
Review Request 72: Improve exception logging
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/72/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
There are several places where we simply log an exception without
any context. This patch adds the exception type to these messages
to improve debugging.
Diffs
-----
src/rolekit/async.py 8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f
src/rolekit/server/decorators.py ae30cd8ad7d16b02accdc95bd0dd0f22cbc581ae
src/rolekit/server/rolebase.py cd28d6a47cf183f6017905034f178d7aecf83348
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/72/diff/
Testing
-------
Thanks,
Stephen Gallagher
9 years, 7 months
Review Request 71: Enable logging of subprocess output
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/71/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
In the original approach, it was impossible to monitor the
progress of a subprocess because all of the stdout/stderr was
being buffered for retrieval only after the process exited.
With this patch, we will now drop stdout into log.debug1() and
stderr into log.error() as they come in (in addition to storing
the complete results for retrieval later). This will make
debugging efforts much simpler.
Diffs
-----
src/rolekit/async.py 8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/71/diff/
Testing
-------
Testing was performed alongside the Domain Controller deployment. With this patch, I was able to see how far along the deployment had gotten.
Thanks,
Stephen Gallagher
9 years, 7 months