March 2015 - rolekit-commits - Fedora Mailing-Lists

Review Request 154: DB: Ignore instances in ERROR state when initializing

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/154/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner. Bugs: 43 https://fedorahosted.org/rolekit/ticket/43 Repository: rolekit Description ------- An instance that failed to deploy should not count as a pre- existing instance. This would prevent the database from being initialized properly. Diffs ----- config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/154/diff/ Testing ------- Created a first instance in error state (no database name, so nothing happened on disk). Created a second instance with correct input. Success. Thanks, Stephen Gallagher

9 years

1
3
0 / 0

Re: Review Request 155: Allow roles to raise INVALID_VALUE and remove the instance

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/155/ ----------------------------------------------------------- (Updated March 31, 2015, 11:25 p.m.) Status ------ This change has been marked as submitted. Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner. Repository: rolekit Description ------- Previously, we could only do limited checks on those options that were provided to the API, but this didn't allow us to check for missing attributes or attributes whose value is dependent on another setting, etc. With this patch, roles will be allowed to raise RolekitError(INVALID_VALUE) as long as they have not yet made any changes to the systemm Diffs ----- src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc Diff: http://reviewboard-fedoraserver.rhcloud.com/r/155/diff/ Testing ------- Attempted to create a database role with no settings file (and therefore no database name). The deployment failed but no invalid instance was left behind. Thanks, Stephen Gallagher

9 years

1
0
0 / 0

Re: Review Request 155: Allow roles to raise INVALID_VALUE and remove the instance

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/155/#review416 ----------------------------------------------------------- Ship it! Ship It! - Simo Sorce On March 31, 2015, 7:26 p.m., Stephen Gallagher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-fedoraserver.rhcloud.com/r/155/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 7:26 p.m.) > > > Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner. > > > Repository: rolekit > > > Description > ------- > > Previously, we could only do limited checks on those options that > were provided to the API, but this didn't allow us to check for > missing attributes or attributes whose value is dependent on > another setting, etc. > > With this patch, roles will be allowed to > raise RolekitError(INVALID_VALUE) > as long as they have not yet made any changes to the systemm > > > Diffs > ----- > > src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc > > Diff: http://reviewboard-fedoraserver.rhcloud.com/r/155/diff/ > > > Testing > ------- > > Attempted to create a database role with no settings file (and therefore no database name). The deployment failed but no invalid instance was left behind. > > > Thanks, > > Stephen Gallagher > >

9 years

1
0
0 / 0

Review Request 155: Allow roles to raise INVALID_VALUE and remove the instance

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/155/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Previously, we could only do limited checks on those options that were provided to the API, but this didn't allow us to check for missing attributes or attributes whose value is dependent on another setting, etc. With this patch, roles will be allowed to raise RolekitError(INVALID_VALUE) as long as they have not yet made any changes to the systemm Diffs ----- src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc Diff: http://reviewboard-fedoraserver.rhcloud.com/r/155/diff/ Testing ------- Attempted to create a database role with no settings file (and therefore no database name). The deployment failed but no invalid instance was left behind. Thanks, Stephen Gallagher

9 years

1
0
0 / 0

Re: Review Request 147: DB: Support multiple instances

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/147/ ----------------------------------------------------------- (Updated March 25, 2015, 8:26 p.m.) Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner. Changes ------- Update based on review. Bugs: 41 https://fedorahosted.org/rolekit/ticket/41 Repository: rolekit Description ------- DB: Support multiple instances Diffs (updated) ----- config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12 src/rolekit/config/__init__.py.in cd0f14f5519247d31ee1380bf5986f701797af78 src/rolekit/errors.py 47a9c95d3bd2d62f0c008693e6d5eb7a48632d67 src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc Diff: http://reviewboard-fedoraserver.rhcloud.com/r/147/diff/ Testing ------- Thanks, Stephen Gallagher

9 years

1
2
0 / 0

Re: Review Request 148: DB: Set a default for DB owner

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/148/ ----------------------------------------------------------- (Updated March 25, 2015, 8:38 p.m.) Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner. Changes ------- Throw an exception if we try to set a password on an existing user. Repository: rolekit Description (updated) ------- We'll use db_owner if it's unspecified. Diffs (updated) ----- config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12 doc/xml/rolekit.roles.databaseserver.xml 112a40c9d8fb0a268e74bc022857bef4587103e8 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/148/diff/ Testing ------- Thanks, Stephen Gallagher

9 years

1
7
0 / 0

Re: Review Request 149: DB: Implement decommission

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/149/ ----------------------------------------------------------- (Updated March 25, 2015, 8:28 p.m.) Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner. Changes ------- Switch to using \_parent Bugs: 40 https://fedorahosted.org/rolekit/ticket/40 Repository: rolekit Description ------- DB: Implement decommission Diffs (updated) ----- config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/149/diff/ Testing ------- Thanks, Stephen Gallagher

9 years

1
2
0 / 0

Review Request 153: DB: Suppress passwords from settings

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/153/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Only display the password in the settings attributes if it was automatically generated. Diffs ----- config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12 doc/xml/rolekit.roles.databaseserver.xml 112a40c9d8fb0a268e74bc022857bef4587103e8 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/153/diff/ Testing ------- Thanks, Stephen Gallagher

9 years

1
1
0 / 0

Review Request 152: rolectl: New --verbose option for list instances to show the state also

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/152/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- rolectl: New --verbose option for list instances to show the state also Diffs ----- src/rolectl 8b358578a9df3fda8450ab636d9eab7ddee3f962 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/152/diff/ Testing ------- Thanks, Thomas Woerner

9 years

1
2
0 / 0

Review Request 151: rolectl: Honor state option in list instances (if set)

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/151/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- rolectl: Honor state option in list instances (if set) Diffs ----- src/rolectl 8b358578a9df3fda8450ab636d9eab7ddee3f962 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/151/diff/ Testing ------- Thanks, Thomas Woerner

9 years

1
2
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

rolekit-commits March 2015