This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/18/

src/rolekit/server/dbusrole.py (Diff revision 1) 
def InstanceAdded(self, name):
256 
            raise RolekitError(TOO_MANY_INSTANCES, "> 1")
 259 
            error_handler(RolekitError(TOO_MANY_INSTANCES, "> 1"))
 
This should be return ...

src/rolekit/server/dbusrole.py (Diff revision 1) 
def InstanceAdded(self, name):
270 
            raise RolekitError(NAME_CONFLICT, instance_escaped_name)
 273 
            error_handler(RolekitError(NAME_CONFLICT, instance_escaped_name))
 
This should be return ...

src/rolekit/server/dbusrole.py (Diff revision 1) 
def InstanceAdded(self, name):
295 
        return role
 298 
        reply_handler(role)
 
I am not sure, but this might also be return ...

- Thomas Woerner


On July 22nd, 2014, 1:40 a.m. UTC, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated July 22, 2014, 1:40 a.m.

Repository: rolekit

Description 

This patch passes two callbacks, reply_handler and error_handler

into the deploy() methods. We can pass these handlers down into

asynchronous functions to allow us to avoid blocking on long-

waiting routines.


This patch prepares the system for async operation but the call to

do_deploy() in the rolebase is still synchronous.

Testing 

I used d-feet to test the deploy() method on the testrole. It behaves as it used to.

Diffs

  • src/rolekit/server/dbusrole.py (6cef7cfeba6a7bbe396601c7ab31fe034757bc6a)
  • src/rolekit/server/rolebase.py (50b5685a038789d02d3f3b0451f5edaecc187964)

View Diff