On August 21st, 2014, 11:36 a.m. UTC, Miloslav Trmac wrote:

src/rolekit/async.py (Diff revision 1)
def start_with_dbus_callbacks(generator, result_handler, error_handler):
168	log.error(str(e))	168	log.error("{0}: {1}".format(type(e), str(e)))

Just curious—is there a reason to use {} and .format instead of %s and ""%(..) ?

I'm trying to get into a habit of always using .format() since it plays better with internationalization. It's probably unnecessary in this case, but it's easiest for me to develop a habit if I do it all the time.

- Stephen

On August 20th, 2014, 8:57 p.m. UTC, Stephen Gallagher wrote:

There are several places where we simply log an exception without
any context. This patch adds the exception type to these messages
to improve debugging.