This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/55/

On July 31st, 2014, 2:44 p.m. UTC, Miloslav Trmac wrote:

src/rolekit/server/dbusrole.py (Diff revision 1)
def PropertiesChanged(self, interface_name, changed_properties,
206
    # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #
206
    # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #
207
    # Private methods
207
    # Private methods

What does “private” mean in this context BTW? It's obviously neither class-private nor file-private.

Private means here that is it not visible via D-Bus.


- Thomas


On July 30th, 2014, 3:33 p.m. UTC, Thomas Woerner wrote:

Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Thomas Woerner.

Updated July 30, 2014, 3:33 p.m.

Repository: rolekit

Description

Fixes https://fedorahosted.org/rolekit/ticket/3

Diffs

  • src/rolekit/server/dbusrole.py (8a13ccccbb0c9d2940f485697d9d2ef644183b15)
  • src/rolekit/server/roled.py (59d1523347325b20d666c99d8c2087c8ce486608)

View Diff