This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/72/

Ship it!

Ship It!

src/rolekit/async.py (Diff revision 1) 
def start_with_dbus_callbacks(generator, result_handler, error_handler):
168 
            log.error(str(e))
 168 
            log.error("{0}: {1}".format(type(e), str(e)))
 
Just curious—is there a reason to use {} and .format instead of %s and ""%(..) ?

- Miloslav Trmac


On srpen 20th, 2014, 10:57 odp. CEST, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated Srp. 20, 2014, 10:57 odp.

Repository: rolekit

Description 

There are several places where we simply log an exception without
any context. This patch adds the exception type to these messages
to improve debugging.

Diffs

  • src/rolekit/async.py (8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f)
  • src/rolekit/server/decorators.py (ae30cd8ad7d16b02accdc95bd0dd0f22cbc581ae)
  • src/rolekit/server/rolebase.py (cd28d6a47cf183f6017905034f178d7aecf83348)

View Diff