This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/71/

On srpen 20th, 2014, 1:18 odp. CEST, Miloslav Trmac wrote:

src/rolekit/async.py (Diff revision 1)
def input_handler(unused_fd, condition, unused_data):
232
                    line_count = len(lines);
233
                    for i in range(line_count - 1):
234
                        log_fn(lines[i])

for line in lines[:-1]: log_fn(line)

… and then use lines[-1] below.


- Miloslav


On srpen 20th, 2014, 4:05 dop. CEST, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated Srp. 20, 2014, 4:05 dop.

Repository: rolekit

Description

In the original approach, it was impossible to monitor the
progress of a subprocess because all of the stdout/stderr was
being buffered for retrieval only after the process exited.

With this patch, we will now drop stdout into log.debug1() and
stderr into log.error() as they come in (in addition to storing
the complete results for retrieval later). This will make
debugging efforts much simpler.

Testing

Testing was performed alongside the Domain Controller deployment. With this patch, I was able to see how far along the deployment had gotten.

Diffs

  • src/rolekit/async.py (8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f)

View Diff