This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/63/

config/roles/domaincontroller/role.py (Diff revision 1)
42 
        "myownsetting": "something",
 47 
                     "services": [ "freeipa-ldap",
43 
        "failonthis": 123,
 48 
                                   "freeipa-ldaps",
 
Don't you need to list kerberos and https ports too ?

(and ntp)

config/roles/domaincontroller/role.py (Diff revision 1) 
def do_stop_async(self, sender=None):
 

    155
    
            props['dm_password'] = props['admin_password']

  


 




 


  
Are we sure it is a good idea to default the DM password to the admin password ?

 









- Simo Sorce






On August 1st, 2014, 9:11 p.m. UTC, Stephen Gallagher wrote:












 

  


Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.


By Stephen Gallagher.




Updated Aug. 1, 2014, 9:11 p.m.












 Repository: 
rolekit





Description 

 

 

  
   
Domain Controller deployment

  		
 






Testing 



 

  
   
Performed a mostly-successful deployment of FreeIPA onto a Fedora 21 VM.


(Mostly-successful because there appears to be an ipa-server-install bug preventing successful completion, but that should be irrelevant to this patch).

  		
 






Diffs 


    

 
  • config/roles/domaincontroller/role.py (358deca3fc7172929d53d2c77efd5c919da2aea9)
    • 





View Diff