This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/62/

See #65 , which does everything on the main thread (at the cost of some ugliness around both GLib and subprocess wanting to use waitpid()).

- Miloslav Trmac

On srpen 4th, 2014, 1:27 odp. CEST, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.

By Stephen Gallagher.

Updated Srp. 4, 2014, 1:27 odp.

Repository: rolekit

Description

This will spawn a thread to monitor the subprocess, capture both
stdout and stderr and throw an exception if the process terminates
with a non-zero error code.

Testing

Manual testing was done by having it call a script that slept for 30s and verifying that other requests could be successfully made to rolekit while it was waiting.

This code probably needs a unit test, but I haven't written it yet.

Diffs

src/rolekit/async.py (1e2b82eab5a4e6862594672f738c1935a83c2be5)

View Diff