This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/18/

Ship it!

Ship It!

src/rolekit/server/rolebase.py (Diff revisions 1 - 2) 
def deploy(self, values,
546 
        try:
 546 
        try:
547 
            self.do_deploy(values, sender)
 547 
            self.do_deploy(values, sender)
548 
        except:
 548 
        except Exception as e:
549 
            self.change_state(NASCENT)
 549 
            self.change_state(NASCENT)
550 
            raise
 550 
            return error_handler(e)
 
Note that there are other pending patches to deploy, which will need converting to the async convention as well.

- Miloslav Trmac


On červenec 22nd, 2014, 4:09 odp. CEST, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated Čec. 22, 2014, 4:09 odp.

Repository: rolekit

Description 

This patch passes two callbacks, reply_handler and error_handler

into the deploy() methods. We can pass these handlers down into

asynchronous functions to allow us to avoid blocking on long-

waiting routines.


This patch prepares the system for async operation but the call to

do_deploy() in the rolebase is still synchronous.

Testing 

I used d-feet to test the deploy() method on the testrole. It behaves as it used to.

Diffs

  • src/rolekit/server/dbusrole.py (6cef7cfeba6a7bbe396601c7ab31fe034757bc6a)
  • src/rolekit/server/rolebase.py (50b5685a038789d02d3f3b0451f5edaecc187964)

View Diff