On srpen 19th, 2014, 4:56 odp. CEST, Miloslav Trmac wrote:

config/roles/testrole/role.py (Diff revision 1)
def do_update(self, sender=None):
105		105
		106	# Check own properties

Documentation IMHO belongs into RoleBase, not to be copy&pasted in all roles.  If necessary, attach it to to a method that only raises NotImplemeted (or returns False?)
Also, please keep the interfaces of all roles in sync (i.e. when adding a method to one, add it to all.)

And finally, having this a docstring instead of a comment would be nice.  Tools understand docstrings.

- Miloslav

On srpen 18th, 2014, 2:03 odp. CEST, Thomas Woerner wrote:

This is needed to be able to check types of role specific properties.