| This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/55/ |
| src/rolekit/server/dbusrole.py (Diff revision 1) | |||
|---|---|---|---|
def PropertiesChanged(self, interface_name, changed_properties, |
|||
| 206 | # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # |
206 | # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # |
| 207 | # Private methods |
207 | # Private methods |
What does “private” mean in this context BTW? It's obviously neither class-private nor file-private.
| src/rolekit/server/dbusrole.py (Diff revision 1) | |||
|---|---|---|---|
def PropertiesChanged(self, interface_name, changed_properties, |
|||
| 209 | @handle_exceptions |
209 | @handle_exceptions |
No. Logging and ignoring exceptions deep within the call stack, and returning None from functions that are not documented to return None, is not a reasonable error handling strategy.
(I’m not working on fixing the other places, but let’s not spread this any further.)
| src/rolekit/server/roled.py (Diff revision 1) | |||
|---|---|---|---|
def getNamedRole(self, name, sender=None): |
|||
| 235 | for obj in self._roles: |
235 | for obj in self._roles: |
| 236 | if obj.name == name: |
236 | if obj.get_name() == name: |
| 237 | return obj |
237 | return obj |
This kind of suggests that ._roles should be a dictionary instead… but that’s for another time.
- Miloslav Trmac
On červenec 30th, 2014, 5:33 odp. CEST, Thomas Woerner wrote:
|
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Thomas Woerner.
Updated Čec. 30, 2014, 5:33 odp.
Repository:
rolekit
Description
Diffs
|