Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.
Updated Aug. 4, 2014, 11:27 a.m.
Changes
Reorder the __all__ variable. Fix reporting return codes from the subprocess (generating an exception does not work)
|
Repository:
rolekit
Description
This will spawn a thread to monitor the subprocess, capture both
stdout and stderr and throw an exception if the process terminates
with a non-zero error code.
|
Testing
Manual testing was done by having it call a script that slept for 30s and verifying that other requests could be successfully made to rolekit while it was waiting.
This code probably needs a unit test, but I haven't written it yet.
|
Diffs (updated)
- src/rolekit/async.py (1e2b82eab5a4e6862594672f738c1935a83c2be5)
View Diff
|