This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/127/

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated Feb. 17, 2015, 6:57 p.m.

Changes

Completely rewrote this patch to use subprocess.PIPE instead. The creation of the temporary file was overthinking the situation (it was attempting to avoid the small risk of deadlock when reading and writing stdin and stdout directly, however, since we're never doing those things at the same time, it's unnecessary).

This version of the patch also adds a test for the stdin functionality by calling 'tee' (which simply shunts stdin to stdout).
Repository: rolekit

Description

Add utility routine for passing stdin into subprocesses

Diffs (updated)

  • src/rolekit/async.py (0f9ddaac1beb27cebdf41ca0383a62a807c4fcb6)
  • tests/async_test.py (12a4c12c8dbf427a6382c9bc82139bf246b08c37)

View Diff