This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/71/ |
On August 20th, 2014, 11:18 a.m. UTC, Miloslav Trmac wrote:
src/rolekit/async.py (Diff revision 1) def input_handler(unused_fd, condition, unused_data):230 # Log the input at debug level 9
“debug level 9” depends on a parameter and is actually not true in any existing invocation.
(Should log_fn even have a default value? I can see the case for having it, but then we are not using it at this moment.)
Whoops, I originally had level 9 hard-coded, then added the parameter and forgot to change the comment.
Yeah, I'll remove the default.
On August 20th, 2014, 11:18 a.m. UTC, Miloslav Trmac wrote:
src/rolekit/async.py (Diff revision 1) def input_handler(unused_fd, condition, unused_data):232 line_count = len(lines);233 for i in range(line_count - 1):234 log_fn(lines[i])for line in lines[:-1]: log_fn(line)
On August 20th, 2014, 12:02 p.m. UTC, Miloslav Trmac wrote:
… and then use lines[-1] below.
Thanks, my C background was showing.
- Stephen
On August 20th, 2014, 2:05 a.m. UTC, Stephen Gallagher wrote:
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.
Updated Aug. 20, 2014, 2:05 a.m.
Repository:
rolekit
Description
Testing
Diffs
|