This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/54/

Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Miloslav Trmac.

Updated Čec. 30, 2014, 12:31 dop.

Repository: rolekit

Description 

Implement starting and stopping services, and use it in databaseserver.


Includes some work-in-progress edits to databaseserver, IMHO harmless enough but will split them if asked.


Now rereading this, should the StartUnit/StopUnit D-Bus calls be non-blocking as well?  At this late hour I’m inclined to say that they are explicitly designed to be returning quickly, so it isn’t really necessary.

Testing 

starting/stopping postgres through d-feet.

Diffs (updated)

  • TODO (053560af7e811ae9d26b7eafff92ac2786af5408)
  • config/roles/databaseserver/role.py (b632321de63c331b3b3d0445d134fe1626e9944c)
  • src/rolekit/dbus_utils.py (fb21cec2681f60ec2ad30372c4caf285e8ba13a7)
  • src/rolekit/server/rolebase.py (d53c745352183944e307cca5259a58f058f81e27)

View Diff