On August 22nd, 2014, 9:17 p.m. UTC, Stephen Gallagher wrote:

This code isn't working at all. I attempted to do a deploy() of the domain controller with this patch attached and hit an unhandled exception:

<type 'exceptions.KeyError'>: 'firewall-changes'
Trying to decommission it, I hit the same exception. I also see

Error: ALREADY_ENABLED: 'freeipa-ldap' already in 'FedoraServer'

if I try to deploy again (this happens before it notices that the instance count is exceeded as well).

This is fixed now.

- Thomas

On August 22nd, 2014, 6:57 p.m. UTC, Thomas Woerner wrote:

installFirewall uses the firewall _settings from the role: firewall and firewall_zones and stores the applied settings in _settings per zone and also for the runtime and permanant firewalld environment.

uninstallFirewall uses the fw_changes _setting from the role and removed them from the zones in runtime and permanent firewalld environment, then clears fw_changes and savet it to _settings again.

updateFirewall calls uninstallFirewall and then installFirewall

_check_property now checks ports to be valid.