| This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/17/ |
| config/roles/testrole/role.py (Diff revision 1) | |||
|---|---|---|---|
def do_update(self, values, sender=None): |
|||
| 100 | # Usage in roles: <class>.get_property(<class>, key) |
99 | # Usage in roles: <class>.get_property(<class>, key) |
| 101 | # Returns values from _DEFAULTS as dbus types |
100 | # Returns values from _DEFAULTS as dbus types |
| 102 | # |
101 | # |
| 103 | # Usage in instances: role.get_property(role, key) |
102 | # Usage in instances: role.get_property(role, key) |
shouldn't you change get_property -> do_get_property ?
| config/roles/testrole/role.py (Diff revision 1) | |||
|---|---|---|---|
def do_update(self, values, sender=None): |
|||
| 123 | # Usage in roles: <class>.get_dbus_property(<class>, key) |
114 | # Usage in roles: <class>.get_dbus_property(<class>, key) |
| 124 | # Returns settings as dbus types |
115 | # Returns settings as dbus types |
| 125 | # |
116 | # |
| 126 | # Usage in instances: role.get_dbus_property(role, key) |
117 | # Usage in instances: role.get_dbus_property(role, key) |
shouldn't you change the examples to do_get_dbus_property() too ?
| config/roles/testrole/role.py (Diff revision 1) | |||
|---|---|---|---|
| 127 | if hasattr(dbus.service, "property"): |
||
| 128 | # property support in dbus.service |
||
| 129 | |||
| 130 | @dbus.service.property(DBUS_INTERFACE_ROLE_INSTANCE, signature='s') |
||
| 131 | @dbus_handle_exceptions |
||
| 132 | def myownsetting(self): |
||
| 133 | return self.get_dbus_property(self, "myownsetting") |
||
is this improperly indented ?
sounds like it should be in do_get_dbus_property() but it isn't this way
- Simo Sorce
On July 22nd, 2014, 3:35 p.m. UTC, Thomas Woerner wrote:
|
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Thomas Woerner.
Updated July 22, 2014, 3:35 p.m.
Repository:
rolekit
Description
Diffs
|