This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/17/ |
config/roles/testrole/role.py (Diff revision 1) | |||
---|---|---|---|
132 | def get_dbus_property(x, prop): |
122 | def do_get_dbus_property(x, prop): |
133 | # At first cover additional settings and return a proper dbus type. |
123 | # Cover additional settings and return a proper dbus type. |
134 | # Then return the result of the call to get_dbus_property of the |
||
135 | # parent class. |
||
136 | if prop == "myownsetting": |
124 | if prop == "myownsetting": |
137 | return dbus.String(x.get_property(x, prop)) |
125 | return dbus.String(x.get_property(x, prop)) |
138 | return super(Role, x).get_dbus_property(x, prop) |
126 | |
127 | if hasattr(dbus.service, "property"): |
||
128 | # property support in dbus.service |
||
129 | |||
130 | @dbus.service.property(DBUS_INTERFACE_ROLE_INSTANCE, signature='s') |
||
131 | @dbus_handle_exceptions |
||
132 | def myownsetting(self): |
||
133 | return self.get_dbus_property(self, "myownsetting") |
Shouldn't this be self.do_get_dbus_property()?
- Stephen Gallagher
On July 22nd, 2014, 3:35 p.m. UTC, Thomas Woerner wrote:
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Thomas Woerner.
Updated July 22, 2014, 3:35 p.m.
Repository:
rolekit
Description
Diffs
|