This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/63/

On August 20th, 2014, 5:21 p.m. UTC, Thomas Woerner wrote:

config/roles/domaincontroller/role.py (Diff revision 2)
def do_update(self, sender=None):
286
        # Do not export the admin_password as that is a user account

if the admin_password may not be exported, then you should return an empty string. Ottherwise "return super(Role, x).get_dbus_property(x, prop)" further down will return it.

I reworked how I'm handling the values here so that I update the 'values' variable so that it won't return the admin_password for saving. I also added an explicit UNKNOWN_SETTING exception if it is directly requested.


- Stephen


On August 20th, 2014, 2:09 a.m. UTC, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
By Stephen Gallagher.

Updated Aug. 20, 2014, 2:09 a.m.

Repository: rolekit

Description

Domain Controller deployment

Testing

Performed a mostly-successful deployment of FreeIPA onto a Fedora 21 VM.

(Mostly-successful because there appears to be an ipa-server-install bug preventing successful completion, but that should be irrelevant to this patch).

Diffs

  • config/roles/domaincontroller/role.py (358deca3fc7172929d53d2c77efd5c919da2aea9)

View Diff