On August 1st, 2014, 11:34 a.m. UTC, Simo Sorce wrote:

config/roles/testrole/role.py (Diff revision 1)
		127	if hasattr(dbus.service, "property"):
		128	# property support in dbus.service
		129
		130	@dbus.service.property(DBUS_INTERFACE_ROLE_INSTANCE, signature='s')
		131	@dbus_handle_exceptions
		132	def myownsetting(self):
		133	return self.get_dbus_property(self, "myownsetting")

is this improperly indented ?

sounds like it should be in do_get_dbus_property() but it isn't this way

It is not in do_get_dbus_property. If property is available in dbus.service, then we are using the new property model (latest Fedora additions to dbus-python), then this method is needed. Otherwise the old model is needed and done automatically in the Get method in RoleBase.

- Thomas

On July 22nd, 2014, 3:35 p.m. UTC, Thomas Woerner wrote:

Simplifies the role interface
Role cleanup by dropping "failonthis" setting