On July 22nd, 2014, 12:56 p.m. UTC, Thomas Woerner wrote:

src/rolekit/server/dbusrole.py (Diff revision 1)
def InstanceAdded(self, name):
295	return role	298	reply_handler(role)

I am not sure, but this might also be return ...

This one is ok, since it is at the end of the function and the return value is ignored, but you're right that it should be explicit.

- Stephen

On July 22nd, 2014, 1:40 a.m. UTC, Stephen Gallagher wrote:

This patch passes two callbacks, reply_handler and error_handler

into the deploy() methods. We can pass these handlers down into

asynchronous functions to allow us to avoid blocking on long-

waiting routines.
This patch prepares the system for async operation but the call to

do_deploy() in the rolebase is still synchronous.

I used d-feet to test the deploy() method on the testrole. It behaves as it used to.