This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/69/

On October 1st, 2014, 9:15 p.m. UTC, Stephen Gallagher wrote:

I'm going to say ShipIt here and open a bug to figure out why the firewall services aren't being revoked during decommission.

Pushed https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=60503883f3ecbb0c15216add999628c16dfb70cb


- Thomas


On October 2nd, 2014, 1:43 p.m. UTC, Thomas Woerner wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Thomas Woerner.

Updated Oct. 2, 2014, 1:43 p.m.

Repository: rolekit

Description

installFirewall uses the firewall _settings from the role: firewall and firewall_zones and stores the applied settings in _settings per zone and also for the runtime and permanant firewalld environment.

uninstallFirewall uses the fw_changes _setting from the role and removed them from the zones in runtime and permanent firewalld environment, then clears fw_changes and savet it to _settings again.

updateFirewall calls uninstallFirewall and then installFirewall

_check_property now checks ports to be valid.

Diffs

  • src/rolekit/server/rolebase.py (95b10c62ff44fbf12d96992bb07fc68d156259ca)

View Diff