|
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.
Updated Aug. 20, 2014, 7:39 p.m.
Changes
Made the logging more pythonic.
Corrected a comment.
|
Repository:
rolekit
Description
In the original approach, it was impossible to monitor the
progress of a subprocess because all of the stdout/stderr was
being buffered for retrieval only after the process exited.
With this patch, we will now drop stdout into log.debug1() and
stderr into log.error() as they come in (in addition to storing
the complete results for retrieval later). This will make
debugging efforts much simpler.
|
Testing
Testing was performed alongside the Domain Controller deployment. With this patch, I was able to see how far along the deployment had gotten.
|
Diffs (updated)
- src/rolekit/async.py (8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f)
View Diff
|