This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/71/

Ship it!

Ship It!

src/rolekit/async.py (Diff revision 2) 
def input_handler(unused_fd, condition, unused_data):
 

    232
    
                    for line in lines[:-1]: log_fn(line)

  


 




 


  
Please use a separate line for the body of the loop, not the hackish way I used (and commit without a re-review).


I’m sorry, I knew I shouldn’t have been lazy about the 4 extra keystrokes but was anyway :(

 









- Miloslav Trmac






On srpen 20th, 2014, 9:39 odp. CEST, Stephen Gallagher wrote:












 

  


Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.


By Stephen Gallagher.




Updated Srp. 20, 2014, 9:39 odp.












 Repository: 
rolekit





Description 

 

 

  
   
In the original approach, it was impossible to monitor the

progress of a subprocess because all of the stdout/stderr was

being buffered for retrieval only after the process exited.


With this patch, we will now drop stdout into log.debug1() and

stderr into log.error() as they come in (in addition to storing

the complete results for retrieval later). This will make

debugging efforts much simpler.

  		
 






Testing 



 

  
   
Testing was performed alongside the Domain Controller deployment. With this patch, I was able to see how far along the deployment had gotten.

  		
 






Diffs 


    

 
  • src/rolekit/async.py (8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f)
    • 





View Diff