Hello, all:
Mamoru Tasaka wrote, at 07/08/2010 06:06 PM +9:00:
Mohammed Morsi wrote, at 07/07/2010 10:37 AM +9:00:
> For those who don't know, the Fedora 14 feature submission deadline is one week
from today,
> Tuesday July 13th
>
>
https://fedoraproject.org/wiki/Releases/14/Schedule
>
> I think it would be great if we can add Ruby 1.8.7 to that feature list,
> and I believe we are pretty much there with the latest ruby rpm
>
>
http://mo.morsi.org/files/rpms/ruby-1.8.7.299-2.fc13.src.rpm
First of all, I appreciate your contribution on ruby187 srpm.
However I see some regressions in your srpm.
- Many document or example files which were present in 1.8.6.x srpm are
now missing.
* -docs rpm now contain copyright files or so only and completely
useless
* -tcltk rpm now misses example files
- -mode subpackage is now missing. If there is some reason for this, please
add proper obsoletes / provides on at least one of the created binary rpm
so that upgrade path won't break, with adding some comments there.
- on i686, Arch-dependent files are now moved from /usr/lib/ruby/1.8/i386-linux
to /usr/lib/ruby/1.8/
* on i386 this is very confusing because there are both arch-dependent and
arch-indepent files under /usr/lib/ruby/1.8 .
- Note that usual package uses /usr/share for arch-independent files and
/usr/lib{,64} for arch-dependent files. Similarly, we should use different
directories for arch-dependent and arch-independent files.
Also, I guess kanarip is now considering to move arch-independent ruby files
to /usr/share for ruby19.
* Also now on i686 build.log conplains:
-----------------------------------------------------------------
DEBUG: warning: File listed twice: /usr/lib/ruby
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/digest
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/digest/bubblebabble.so
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/digest/md5.so
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/digest/rmd160.so
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/digest/sha1.so
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/digest/sha2.rb
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/digest/sha2.so
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/io
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/io/nonblock.rb
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/io/wait.so
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/racc
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/racc/cparse.so
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/racc/parser.rb
DEBUG: warning: File listed twice: /usr/lib/ruby/1.8/rbconfig.rb
DEBUG: warning: File listed twice: /usr/lib/ruby/site_ruby
DEBUG: warning: File listed twice: /usr/lib/ruby/site_ruby/1.8
DEBUG: warning: File listed twice: /usr/lib/ruby/site_ruby/1.8/i386-linux
-----------------------------------------------------------------
Please move arch-dependent files to /usr/lib/ruby/1.8/i386-linux as before
Other comments:
- Please write some comments what the patches in the srpm is for.
Also please comment if the patches are fedora-specific or not:
https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_ha...
It seems that binary rpms rebuilt from your srpm basically works
on i686, thank you.
Regards,
Mamoru