Dne 19. 01. 22 v 13:08 Pavel Valena napsal(a):
On Wed, Jan 19, 2022 at 11:55 AM Vít Ondruch
<vondruch(a)redhat.com> wrote:
> In my repo, there is missing this change:
>
> ~~~
>
> $ git show 4f6a504c2e9980688763e2164ad0a12c8fdcb9b7
> commit 4f6a504c2e9980688763e2164ad0a12c8fdcb9b7
> Author: Vít Ondruch <vondruch(a)redhat.com>
> Date: Mon Jan 17 17:34:57 2022 +0100
>
> Disable some Fiddle test by libffi-3.4.2.
>
> diff --git a/ruby.spec b/ruby.spec
> index bed0ad0..145791c 100644
> --- a/ruby.spec
> +++ b/ruby.spec
> @@ -921,6 +921,11 @@ DISABLE_TESTS="$DISABLE_TESTS -n
> !/TestAddressResolve#test_socket_getnameinfo_do
> DISABLE_TESTS="$DISABLE_TESTS -n
> !/TestReadline#test_interrupt_in_other_thread/"
> %endif
>
> +# Several test broken by libffi-3.4.2. There should be fix in libffi, once
> +# other components are fixed.
> +#
https://bugzilla.redhat.com/show_bug.cgi?id=2040380
> +mv test/fiddle/test_import.rb{,.disable}
> +
> # Give an option to increase the timeout in tests.
> #
https://bugs.ruby-lang.org/issues/16921
> %{?test_timeout_scale:RUBY_TEST_TIMEOUT_SCALE="%{test_timeout_scale}"}
\
>
> ~~~
>
>
> I still have not decided where to push this. Maybe I should push this
> even to Rawhide, because otherwise the mass rebuild is going to fail. I
> have hoped that this could be already resolved, but it is not :/
Well, +1 for disabling the test. I'd rather have Ruby build.
If nothing else, we should have build against the new FFI ready
(although scratch build strangely failed on s390x).
BTW I have pushed all changes for Ruby 3.1.to my fork: