Hello stahnma, Good to see this review. I was thinking about gemification myself, but you were faster. As of timing of this review, the earliest possibility to build in Koji will be as soon as we will get the promised tag [1]. We were supposed to get it yesterday, but unfortunately it did not happened yet :/ Regarding the spec, of course Bohuslav's notes applies and I had some more: * One of the biggest changes in packaging guidelines and folder structure is the move of binary gem libraries into dedicated folder under /usr/lib{,64}. For this purpose, there is "%gem_extdir" macro [2] defined in macros.rubygems. So according to the guidelines [3] you should replace: pushd %{buildroot}%{gem_instdir} ln -s lib/shadow.so . popd by mkdir -p %{buildroot}%{gem_dir}/lib mv %{buildroot}%{gem_instdir}/lib/shadow.so %{buildroot}%{gem_extdir}/lib and you need to adjust the %files section appropriately, so change: %{gem_instdir}/*so to %exclude %{gem_instdir}/lib %dir %{gem_extdir} %{gem_extdir}/lib * We have new "%gem_spec" macro, so you should use it: %{gem_dir}/specifications/%{gem_name}-%{version}.gemspec => %{gem_spec} * We have new "%gem_docdir" macro: %doc %{gem_dir}/doc/%{gem_name}-%{version} => %doc %{gem_docdir} * I would move %{gem_instdir}/*gemspec into -doc subpackage, since it is not runtime dependency. * I would use %exclude in %files section instead of the "rm", but it's more of personal preference. * You have specified wrong license (at least it differs from the original package, I did not checked it further). BTW, are you aware about Bohuslav's work [4, 5], where he published all changes needed for all Ruby 1.9.3 packages, including Puppet? Vit [1] https://fedorahosted.org/rel-eng/ticket/5016 [2] https://github.com/voxik/ruby.spec/commit/ab15bdaa728f11ea2e9adb570b305ef... [3] https://fedoraproject.org/wiki/PackagingDrafts/Ruby#RubyGem_with_extensio... [4] http://lists.fedoraproject.org/pipermail/ruby-sig/2011-December/000729.html [5] http://lists.fedoraproject.org/pipermail/ruby-sig/2011-December/000735.html Dne 17.1.2012 18:30, Michael Stahnke napsal(a):

On Wed, Jan 18, 2012 at 1:16 PM, Michael Stahnke <mastahnke(a)gmail.com&gt; wrote: Just saw that the commit looked to be fairly recent. I'm rebasing my build of ruby.spec and I imagine that will fix it.