From: "Vít Ondruch" <vondruch(a)redhat.com&gt; To: ruby-sig(a)lists.fedoraproject.org Sent: Monday, October 16, 2017 9:56:44 AM Subject: Re: A macro to build rpms/ruby without systemtap dependency I think it makes sense. Please either open ticket in BZ or send a PR in Pagure. Thx Vít Dne 15.10.2017 v 11:00 Jun Aruga napsal(a): Hello, I am working for ruby module. https://src.fedoraproject.org/modules/ruby I want a macro definition to build the ruby without systemtap rpm (+ dtrace command), such as below macro. %global with_rubypick 1

Hi, > I think it makes sense. Please either open ticket in BZ or send a PR in Pagure. OK I will open ticket in BZ and send the PR in Pagure.

I am not sure that "module capability"'s meaning. But the macro variable is defined as a module scope. Ref. https://src.fedoraproject.org/modules/perl/blob/master/f/perl.yaml#_161 > %{?!global with_rubypick:%global with_rubypick 1} I am not sure if your mentioned code is correct.

I am going to refer below code that we know as a bootstrap logic, and also refer above Perl's logic. %{?_with_bootstrap: %global bootstrap 1} Jun On Mon, Oct 16, 2017 at 12:39 PM, Pavel Valena <pvalena(a)redhat.com <mailto:pvalena@redhat.com>> wrote: ----- Original Message ----- > From: "Vít Ondruch" <vondruch(a)redhat.com <mailto:vondruch@redhat.com>> > To: ruby-sig(a)lists.fedoraproject.org <mailto:ruby-sig@lists.fedoraproject.org> > Sent: Monday, October 16, 2017 9:56:44 AM > Subject: Re: A macro to build rpms/ruby without systemtap dependency > > > > I think it makes sense. Please either open ticket in BZ or send a PR in > Pagure. > > > > > Thx > > > > > Vít > > > > Dne 15.10.2017 v 11:00 Jun Aruga napsal(a): > > > > Hello, > > I am working for ruby module. > https://src.fedoraproject.org/modules/ruby <https://src.fedoraproject.org/modules/ruby> > > I want a macro definition to build the ruby without systemtap rpm (+ dtrace > command), such as below macro. > > %global with_rubypick 1 Is it not a module capability to change/define spec file macros? Then it would be possible to change the above to[AFAIR]: %{?!global with_rubypick:%global with_rubypick 1} And then override it on module to 0. Feel free to correct me if I'm wrong. Pavel > > Because it is uncertainly when systemtap module will be prepared or not right > now. > > Is it possible to update ruby.spec for that? > > Jun -- Jun Aruga jaruga(a)redhat.com <mailto:jaruga@redhat.com> IRC: jaruga, Office: TPB(Technology Park Brno) Building C 1F, Brno, Czech Republic _______________________________________________ ruby-sig mailing list -- ruby-sig(a)lists.fedoraproject.org To unsubscribe send an email to ruby-sig-leave(a)lists.fedoraproject.org

Vit, I will just create BZ for that. I would like to ask you guys for the task. If ruby.spec has a macro that ruby does not depends on systemtap, I am fine for any way. Please implement it as you like. Jun On Tue, Oct 17, 2017 at 7:42 AM, Vít Ondruch <vondruch(a)redhat.com&gt; wrote: > > > Dne 17.10.2017 v 07:33 Jun Aruga napsal(a): > > Hi, > > > I think it makes sense. Please either open ticket in BZ or send a PR in > Pagure. > > OK I will open ticket in BZ and send the PR in Pagure. > > > One or the other is enough, you won't get more attention opening PR as > well as BZ ticket. > > > > I am not sure that "module capability"'s meaning. > But the macro variable is defined as a module scope. > Ref. https://src.fedoraproject.org/modules/perl/blob/master/f/per > l.yaml#_161 > > > %{?!global with_rubypick:%global with_rubypick 1} > > I am not sure if your mentioned code is correct. > > > Of course the first "global" should not be there, but you get the picture > ... > > Anyway, the details are probably better to discuss in the PR (as soon as > it is sent), otherwise this is just academic ... > > > > V. > > > I am going to refer below code that we know as a bootstrap logic, and > also refer above Perl's logic. > > %{?_with_bootstrap: %global bootstrap 1} > > Jun > > > > On Mon, Oct 16, 2017 at 12:39 PM, Pavel Valena <pvalena(a)redhat.com&gt; > wrote: > >> ----- Original Message ----- >> > From: "Vít Ondruch" <vondruch(a)redhat.com&gt; >> > To: ruby-sig(a)lists.fedoraproject.org >> > Sent: Monday, October 16, 2017 9:56:44 AM >> > Subject: Re: A macro to build rpms/ruby without systemtap dependency >> > >> > >> > >> > I think it makes sense. Please either open ticket in BZ or send a PR in >> > Pagure. >> > >> > >> > >> > >> > Thx >> > >> > >> > >> > >> > Vít >> > >> > >> > >> > Dne 15.10.2017 v 11:00 Jun Aruga napsal(a): >> > >> > >> > >> > Hello, >> > >> > I am working for ruby module. >> > https://src.fedoraproject.org/modules/ruby >> > >> > I want a macro definition to build the ruby without systemtap rpm (+ >> dtrace >> > command), such as below macro. >> > >> > %global with_rubypick 1 >> >> Is it not a module capability to change/define spec file macros? >> Then it would be possible to change the above to[AFAIR]: >> >> %{?!global with_rubypick:%global with_rubypick 1} >> >> And then override it on module to 0. >> >> Feel free to correct me if I'm wrong. >> >> Pavel >> >> > >> > Because it is uncertainly when systemtap module will be prepared or >> not right >> > now. >> > >> > Is it possible to update ruby.spec for that? >> > >> > Jun >> > > > > -- > Jun Aruga jaruga(a)redhat.com > IRC: jaruga, Office: TPB(Technology Park Brno) Building C 1F, Brno, Czech > Republic > > > > _______________________________________________ > ruby-sig mailing list -- ruby-sig(a)lists.fedoraproject.org > To unsubscribe send an email to ruby-sig-leave(a)lists.fedoraproject.org > > > > _______________________________________________ > ruby-sig mailing list -- ruby-sig(a)lists.fedoraproject.org > To unsubscribe send an email to ruby-sig-leave(a)lists.fedoraproject.org > > -- Jun Aruga jaruga(a)redhat.com IRC: jaruga, Office: TPB(Technology Park Brno) Building C 1F, Brno, Czech Republic