On Wed, May 15, 2019 at 2:27 PM Vojtech Juranek <vjuranek@redhat.com> wrote:
looks good to me

On úterý 14. května 2019 22:45:03 CEST Nir Soffer wrote:
> These patches should be included in sanlock 3.8, but they should be
> harmless if we include them in 3.7.
>
> Amit Bawer (5):
>   readme: Add prerequisites section
>   tox: Add python version as make argument
>   tests: Use python3 and python2 compatible socket exception type
>   tests: Lockspace and resource names should be read as bytes
>   tests: Enforce absolute import behavior for python2 tests

I will send a v2 with some minor modifications and new patches
next week.
 
>
>  README.dev           | 12 ++++++++++++
>  python/Makefile      |  6 ++++--
sanlock.spec.in      |  3 ++-
>  tests/conftest.py    |  1 +
>  tests/daemon_test.py | 11 ++++++-----
>  tests/direct_test.py |  1 +
>  tests/python_test.py | 19 ++++++++++---------
>  tests/util.py        |  5 +++--
>  tox.ini              |  3 ++-
>  9 files changed, 41 insertions(+), 20 deletions(-)
>
> --
> 2.17.2
> _______________________________________________
> sanlock-devel mailing list -- sanlock-devel@lists.fedorahosted.org
> To unsubscribe send an email to sanlock-devel-leave@lists.fedorahosted.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedorahosted.org/archives/list/sanlock-devel@lists.fedorahost
> ed.org

_______________________________________________
sanlock-devel mailing list -- sanlock-devel@lists.fedorahosted.org
To unsubscribe send an email to sanlock-devel-leave@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedorahosted.org/archives/list/sanlock-devel@lists.fedorahosted.org