On Thu, Oct 6, 2022 at 5:12 PM Albert Esteve <aesteve(a)redhat.com&gt; wrote: Only libuuid-devel is needed: $ dnf repoquery --requires libuuid-devel ... /usr/bin/pkg-config libuuid(x86-32) = 2.38-0.2.fc36 libuuid(x86-32) = 2.38-1.fc36 libuuid(x86-64) = 2.38-0.2.fc36 libuuid(x86-64) = 2.38-1.fc36 libuuid.so.1 libuuid.so.1()(64bit) pkgconfig As you did here

Remove the outdated version of userstorage that is stored locally at tests/storage.py Change it so that it uses the version obtained from PyPI, and add it as a tox dependency for tests. Behaviour for missing storage and folder structure remains as originally intended. Fixture is adapted to new style so that is uses setup and teardown before and after every test, respectively. Signed-off-by: Albert Esteve <aesteve(a)redhat.com&gt; --- tests/conftest.py | 21 +++--- tests/storage.py | 161 +++++++--------------------------------------- tox.ini | 1 + 3 files changed, 34 insertions(+), 149 deletions(-) diff --git a/tests/conftest.py b/tests/conftest.py index b40852b..5434772 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -9,13 +9,16 @@ Fixtures for sanlock testing. """ from __future__ import absolute_import -import os - import pytest +import userstorage -from . import storage from . import util +# Mark tests with xfail if userstorage is missing +userstorage.missing_handler = pytest.xfail + +# Requires relative path from tox basedir +BACKENDS = userstorage.load_config("./tests/storage.py").BACKENDS class SanlockIsRunning(Exception): """ Raised if sanlock running when it should not """ @@ -38,8 +41,8 @@ def sanlock_daemon(): @pytest.fixture(params=[ - pytest.param(storage.BLOCK, id="block"), - pytest.param(storage.FILE, id="file"), + BACKENDS["block"], + BACKENDS["file"], ]) def user_4k_path(request): """ @@ -48,11 +51,9 @@ def user_4k_path(request): If storage is not available, skip the tests. """ - if not os.path.exists(request.param): - pytest.skip( - "user storage available - run 'python tests/strorage.py setup' " - "to enable 4k storage tests") - return request.param + backend = request.param + with backend: + yield backend.path @pytest.fixture diff --git a/tests/storage.py b/tests/storage.py index 0fe6f56..0b12e47 100644 --- a/tests/storage.py +++ b/tests/storage.py @@ -8,145 +8,28 @@ storage - provide storage for sanlock tests. """ -import argparse -import errno -import logging -import os -import subprocess +from userstorage import File, Mount, LoopDevice -BASE_DIR = "/var/tmp/sanlock-storage" -MOUNTPOINT = os.path.join(BASE_DIR, "mnt") - -# For testing sanlock with 4k block device. -LOOP1 = os.path.join(BASE_DIR, "loop1") -BACKING1 = os.path.join(BASE_DIR, "backing1") - -# For testing sanlock with a filesystem backed by 4k block device. -LOOP2 = os.path.join(BASE_DIR, "loop2") -BACKING2 = os.path.join(BASE_DIR, "backing2") - -# Test paths. -BLOCK = LOOP1 -FILE = os.path.join(MOUNTPOINT, "file") - -log = logging.getLogger("storage") - - -def main(): - parser = argparse.ArgumentParser( - description='Storage helper for sanlock tests') - parser.add_argument("command", choices=["setup", "teardown"]) - args = parser.parse_args() - - logging.basicConfig(level=logging.INFO, format="storage: %(message)s") - - if args.command == "setup": - setup() - elif args.command == "teardown": - teardown() - - -def setup(): - create_dir(BASE_DIR) - - if not os.path.exists(LOOP1): - create_loop_device(LOOP1, BACKING1) - - if not os.path.exists(LOOP2): - create_loop_device(LOOP2, BACKING2) - create_dir(MOUNTPOINT) - create_filesystem(LOOP2, MOUNTPOINT) - - # Sanlock allocates spaces as needed. - with open(FILE, "wb") as f: - f.truncate(0) - - -def teardown(): - if is_mounted(MOUNTPOINT): - remove_filesystem(MOUNTPOINT) - - if os.path.exists(LOOP2): - remove_loop_device(LOOP2, BACKING2) - - if os.path.exists(LOOP1): - remove_loop_device(LOOP1, BACKING1) - - -def create_loop_device(link_path, backing_file, size=1024**3, - sector_size=4096): - log.info("Creating loop device %s", link_path) - - with open(backing_file, "wb") as f: - f.truncate(size) - - out = subprocess.check_output([ - "sudo", - "losetup", - "-f", backing_file, - "--sector-size", str(sector_size), - "--show", - ]) - - device = out.decode("utf-8").strip() - - # Remove stale symlink. - if os.path.islink(link_path): - os.unlink(link_path) - - os.symlink(device, link_path) - chown(link_path) - - -def remove_loop_device(link_path, backing_file): - log.info("Removing loop device %s", link_path) - - subprocess.check_call(["sudo", "losetup", "-d", link_path]) - remove_file(link_path) - remove_file(backing_file) - - -def create_filesystem(device, mountpoint): - log.info("Creating filesystem %s", mountpoint) - - subprocess.check_call(["sudo", "mkfs.xfs", "-q", device]) - subprocess.check_call(["sudo", "mount", device, mountpoint]) - chown(mountpoint) - - -def remove_filesystem(mountpoint): - log.info("Removing filesystem %s", mountpoint) - subprocess.check_call(["sudo", "umount", mountpoint]) - - -def is_mounted(mountpoint): - with open("/proc/self/mounts") as f: - for line in f: - if mountpoint in line: - return True - return False - - -def chown(path): - user_group = "%(USER)s:%(USER)s" % os.environ - subprocess.check_call(["sudo", "chown", user_group, path]) - - -def create_dir(path): - try: - os.makedirs(path) - except EnvironmentError as e: - if e.errno != errno.EEXIST: - raise - - -def remove_file(path): - try: - os.remove(path) - except EnvironmentError as e: - if e.errno != errno.ENOENT: - raise +GiB = 1024**3 +BASE_DIR = "/var/tmp/sanlock-storage" -if __name__ == "__main__": - main() +BACKENDS = { + + "file": + File( + Mount( + LoopDevice( + base_dir=BASE_DIR, + name="file", + size=GiB, + sector_size=4096))), + + "block": + LoopDevice( + base_dir=BASE_DIR, + name="loop", + size=GiB, + sector_size=4096), + +} diff --git a/tox.ini b/tox.ini index 8847b34..c0cf5a1 100644 --- a/tox.ini +++ b/tox.ini @@ -17,6 +17,7 @@ setenv = whitelist_externals = make deps = pytest + userstorage>=0.5.1 commands = py{36,37,38,39,310}: make BUILDARGS="--build-lib={envsitepackagesdir}" pytest {posargs} -- 2.37.3

On Thu, Oct 6, 2022 at 5:12 PM Albert Esteve <aesteve(a)redhat.com&gt; wrote: This is better required using a requirements.txt file with tox. Since we must create the storage before running tox, the userstorage package should be installed with tox in a virtual environment.

On Thu, Oct 6, 2022 at 5:12 PM Albert Esteve <aesteve(a)redhat.com&gt; wrote: Installing user storage like this is not a good idea - this will try to install it as root. We show here how to create a virtual environment and install the packages required for sanlock testing (tox, userstorage), and how to activate and deactivate the environment.