NACK. This is mostly just a copy of a file from another directory. Why is there code to handle packages?
On Sat, Jun 1, 2013 at 5:20 PM, Shawn Wells shawn.d.wells@gmail.com wrote:
scap-security-guide mailing list scap-security-guide@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/scap-security-guide
On 6/1/13 7:01 PM, Jeffrey Blank wrote:
NACK. This is mostly just a copy of a file from another directory.
What are thoughts on creating a combined bash+OVAL RHEL6/templates directory? If things can have template OVAL, they should e able to have template bash as well. Might as well put everything together.
Why is there code to handle packages?
Not sure why I didn't see that. Deleted:
if packagename:filestring = filestring.replace("PACKAGENAME", packagename)else:filestring = re.sub("\n\s*<criteria.*>\n\s*<extend_definition.*/>", "", filestring)filestring = re.sub("\s*</criteria>\n\s*</criteria>", "\n </criteria>", filestring)
Okay, then this is fine for a push.
Combining the two into a common templates directory is undesirable to me. I don't want remediation to get in the way of delivering security guidance and checking content, so I'd prefer to keep them separate if possible. Using common CSV files is pretty good already with regard to maintaining linkage. SSG will be ready for remediation content when the checks function properly and there is a well-defined process for contribution for those who know bash that minimizes their need to interact with the raw SCAP content. This would include instructions for how to add new fix scripts, conduct unit tests (to include parameters), and instructions for using oscap to generate fixes. These things are not there yet.
On Sat, Jun 1, 2013 at 8:09 PM, Shawn Wells shawn@redhat.com wrote:
On 6/1/13 7:01 PM, Jeffrey Blank wrote:
NACK. This is mostly just a copy of a file from another directory.
What are thoughts on creating a combined bash+OVAL RHEL6/templates directory? If things can have template OVAL, they should e able to have template bash as well. Might as well put everything together.
Why is there code to handle packages?
Not sure why I didn't see that. Deleted:
if packagename:filestring = filestring.replace("**PACKAGENAME",packagename)
else:filestring = re.sub("\n\s*<criteria.*>\n\s***<extend_definition.*/>","", filestring)
filestring = re.sub("\s*</criteria>\n\s*</**criteria>", "\n______________________________**_________________ scap-security-guide mailing list scap-security-guide@lists.**fedorahosted.orgscap-security-guide@lists.fedorahosted.org https://lists.fedorahosted.**org/mailman/listinfo/scap-**security-guidehttps://lists.fedorahosted.org/mailman/listinfo/scap-security-guide
On 6/1/13 8:09 PM, Shawn Wells wrote:
On 6/1/13 7:01 PM, Jeffrey Blank wrote:
NACK. This is mostly just a copy of a file from another directory.
What are thoughts on creating a combined bash+OVAL RHEL6/templates directory? If things can have template OVAL, they should e able to have template bash as well. Might as well put everything together.
Why is there code to handle packages?
Not sure why I didn't see that. Deleted:
if packagename:filestring = filestring.replace("PACKAGENAME", packagename)else:filestring =re.sub("\n\s*<criteria.*>\n\s*<extend_definition.*/>", "", filestring)
filestring = re.sub("\s*</criteria>\n\s*</criteria>","\n </criteria>", filestring)
bump
did this take care of the concerns?
On 6/9/13 12:19 AM, Shawn Wells wrote:
On 6/1/13 8:09 PM, Shawn Wells wrote:
On 6/1/13 7:01 PM, Jeffrey Blank wrote:
NACK. This is mostly just a copy of a file from another directory.
What are thoughts on creating a combined bash+OVAL RHEL6/templates directory? If things can have template OVAL, they should e able to have template bash as well. Might as well put everything together.
Why is there code to handle packages?
Not sure why I didn't see that. Deleted:
if packagename:filestring = filestring.replace("PACKAGENAME",packagename)
else:filestring =re.sub("\n\s*<criteria.*>\n\s*<extend_definition.*/>", "", filestring)
filestring = re.sub("\s*</criteria>\n\s*</criteria>","\n </criteria>", filestring)
bump
did this take care of the concerns?
scratch that -- just saw jeff's ack
scap-security-guide@lists.fedorahosted.org
-
Jeffrey Blank -
Shawn Wells -
Shawn Wells