java/code/src/com/redhat/rhn/frontend/action/CSVDownloadAction.java | 1 +
java/code/webapp/WEB-INF/pages/systems/details/audit/xccdfdetails.jsp | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
New commits:
commit b1620358d214a00ed6c0eae93ff362e669bb8d9e
Author: Simon Lukasik <slukasik(a)redhat.com>
Date: Thu May 2 09:12:48 2013 +0200
Print stack trace in case of CSV failures.
Even though there is a polite error page for CSV failures,
the stack trace may turn out to be more helpful.
diff --git a/java/code/src/com/redhat/rhn/frontend/action/CSVDownloadAction.java
b/java/code/src/com/redhat/rhn/frontend/action/CSVDownloadAction.java
index 1cca361..fb9e21d 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/CSVDownloadAction.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/CSVDownloadAction.java
@@ -67,6 +67,7 @@ public class CSVDownloadAction extends DownloadAction {
* Overridden to redirect for case of errors while processing CSV Export,
* example: Session timeout.
*/
+ e.printStackTrace();
return mapping.findForward("error");
}
return null;
commit ff626d1210bfd3587dfbf3a1e58da7328e3d6bb1
Author: Simon Lukasik <slukasik(a)redhat.com>
Date: Thu May 2 08:02:24 2013 +0200
958654 - Use different listSetName for the XccdfDetail page.
The list on XccdfDetails page does not have any elaborator
and the list allows the export to CSV. However, when there
was another page with the same listSetName and this page
had bound elaborator to this name --> Our CSV export will
try to evaluate this elaborator.
Such bug may easily remain unnoticed, as the majority of
elaborators use the 'id' attribute. Unfortunatelly, this
one used 'xid'.
Addressing:
com.redhat.rhn.common.db.datasource.MapColumnNotFoundException: Column, xid, not found
in driving query results
at
com.redhat.rhn.common.db.datasource.CachedStatement.executeElaboratorBatch(CachedStatement.java:391)
at
com.redhat.rhn.common.db.datasource.CachedStatement.executeElaborator(CachedStatement.java:363)
at com.redhat.rhn.common.db.datasource.SelectMode.elaborate(SelectMode.java:164)
at
com.redhat.rhn.common.db.datasource.ModeElaborator.elaborate(ModeElaborator.java:48)
at
com.redhat.rhn.frontend.action.CSVDownloadAction.getStreamInfo(CSVDownloadAction.java:201)
at org.apache.struts.actions.DownloadAction.execute(DownloadAction.java:104)
at
com.redhat.rhn.frontend.action.CSVDownloadAction.execute(CSVDownloadAction.java:66)
at
org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:425)
at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:228)
diff --git a/java/code/webapp/WEB-INF/pages/systems/details/audit/xccdfdetails.jsp
b/java/code/webapp/WEB-INF/pages/systems/details/audit/xccdfdetails.jsp
index 43e5673..0b83133 100644
--- a/java/code/webapp/WEB-INF/pages/systems/details/audit/xccdfdetails.jsp
+++ b/java/code/webapp/WEB-INF/pages/systems/details/audit/xccdfdetails.jsp
@@ -86,7 +86,7 @@
<h2><bean:message
key="system.audit.xccdfdetails.jsp.xccdfrules"/></h2>
-<rl:listset name="groupSet">
+<rl:listset name="xccdfDetails">
<rhn:csrf/>
<rl:list>
<rl:decorator name="PageSizeDecorator"/>
@@ -94,7 +94,7 @@
<%@ include
file="/WEB-INF/pages/common/fragments/audit/rule-common-columns.jspf" %>
</rl:list>
- <rl:csv name="groupSet"
+ <rl:csv name="xccdfDetails"
exportColumns="id,documentIdref,identsString,evaluationResult"/>
</rl:listset>
Show replies by date