Hi,
I found this wrong return value. I've checked the other recent posting and didn't found a patch for this. If someone already send a patch for this please point me to the right thread so that I can ack it.
bye, Sumit
On (11/06/14 20:54), Sumit Bose wrote:
Hi,
I found this wrong return value. I've checked the other recent posting and didn't found a patch for this. If someone already send a patch for this please point me to the right thread so that I can ack it.
bye, Sumit
From 9c3d4f637d80448922779b093fc4a2da909054e4 Mon Sep 17 00:00:00 2001 From: Sumit Bose sbose@redhat.com Date: Wed, 11 Jun 2014 20:49:31 +0200 Subject: [PATCH] Fix return value of attr_name_val_split()
src/tools/sss_sync_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tools/sss_sync_ops.c b/src/tools/sss_sync_ops.c index 232a711..667c8a6 100644 --- a/src/tools/sss_sync_ops.c +++ b/src/tools/sss_sync_ops.c @@ -83,7 +83,7 @@ static int attr_name_val_split(TALLOC_CTX *mem_ctx, const char *nameval, ret = EOK; done: talloc_free(tmp_ctx);
- return EOK;
- return ret;
ACK, but could you also change the same problem in "static int attr_op" (the same file).
LS
On Thu, Jun 12, 2014 at 09:21:55AM +0200, Lukas Slebodnik wrote:
On (11/06/14 20:54), Sumit Bose wrote:
Hi,
I found this wrong return value. I've checked the other recent posting and didn't found a patch for this. If someone already send a patch for this please point me to the right thread so that I can ack it.
bye, Sumit
From 9c3d4f637d80448922779b093fc4a2da909054e4 Mon Sep 17 00:00:00 2001 From: Sumit Bose sbose@redhat.com Date: Wed, 11 Jun 2014 20:49:31 +0200 Subject: [PATCH] Fix return value of attr_name_val_split()
src/tools/sss_sync_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tools/sss_sync_ops.c b/src/tools/sss_sync_ops.c index 232a711..667c8a6 100644 --- a/src/tools/sss_sync_ops.c +++ b/src/tools/sss_sync_ops.c @@ -83,7 +83,7 @@ static int attr_name_val_split(TALLOC_CTX *mem_ctx, const char *nameval, ret = EOK; done: talloc_free(tmp_ctx);
- return EOK;
- return ret;
ACK, but could you also change the same problem in "static int attr_op" (the same file).
Thank you, good catch, new version attached.
bye, Sumit
LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On (12/06/14 10:31), Sumit Bose wrote:
On Thu, Jun 12, 2014 at 09:21:55AM +0200, Lukas Slebodnik wrote:
On (11/06/14 20:54), Sumit Bose wrote:
Hi,
I found this wrong return value. I've checked the other recent posting and didn't found a patch for this. If someone already send a patch for this please point me to the right thread so that I can ack it.
bye, Sumit
From 9c3d4f637d80448922779b093fc4a2da909054e4 Mon Sep 17 00:00:00 2001 From: Sumit Bose sbose@redhat.com Date: Wed, 11 Jun 2014 20:49:31 +0200 Subject: [PATCH] Fix return value of attr_name_val_split()
src/tools/sss_sync_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tools/sss_sync_ops.c b/src/tools/sss_sync_ops.c index 232a711..667c8a6 100644 --- a/src/tools/sss_sync_ops.c +++ b/src/tools/sss_sync_ops.c @@ -83,7 +83,7 @@ static int attr_name_val_split(TALLOC_CTX *mem_ctx, const char *nameval, ret = EOK; done: talloc_free(tmp_ctx);
- return EOK;
- return ret;
ACK, but could you also change the same problem in "static int attr_op" (the same file).
Thank you, good catch, new version attached.
bye, Sumit
From 1bcb5a8a6e9d4c032d5599ee900002a863ae8a4a Mon Sep 17 00:00:00 2001 From: Sumit Bose sbose@redhat.com Date: Wed, 11 Jun 2014 20:49:31 +0200 Subject: [PATCH] Fix return value of attr_name_val_split() and attr_op()
this patch also fix gcc warnings src/tools/sss_sync_ops.c:94: warning: 'name' may be used uninitialized in this function src/tools/sss_sync_ops.c:95: warning: 'vals' may be used uninitialized in this function src/tools/sss_sync_ops.c:96: warning: 'nvals' may be used uninitialized in this function
ACK
LS
On Thu, 2014-06-12 at 15:15 +0200, Lukas Slebodnik wrote:
On (12/06/14 10:31), Sumit Bose wrote:
On Thu, Jun 12, 2014 at 09:21:55AM +0200, Lukas Slebodnik wrote:
On (11/06/14 20:54), Sumit Bose wrote:
Hi,
I found this wrong return value. I've checked the other recent posting and didn't found a patch for this. If someone already send a patch for this please point me to the right thread so that I can ack it.
bye, Sumit
From 9c3d4f637d80448922779b093fc4a2da909054e4 Mon Sep 17 00:00:00 2001 From: Sumit Bose sbose@redhat.com Date: Wed, 11 Jun 2014 20:49:31 +0200 Subject: [PATCH] Fix return value of attr_name_val_split()
src/tools/sss_sync_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tools/sss_sync_ops.c b/src/tools/sss_sync_ops.c index 232a711..667c8a6 100644 --- a/src/tools/sss_sync_ops.c +++ b/src/tools/sss_sync_ops.c @@ -83,7 +83,7 @@ static int attr_name_val_split(TALLOC_CTX *mem_ctx, const char *nameval, ret = EOK; done: talloc_free(tmp_ctx);
- return EOK;
- return ret;
ACK, but could you also change the same problem in "static int attr_op" (the same file).
Thank you, good catch, new version attached.
bye, Sumit
From 1bcb5a8a6e9d4c032d5599ee900002a863ae8a4a Mon Sep 17 00:00:00 2001 From: Sumit Bose sbose@redhat.com Date: Wed, 11 Jun 2014 20:49:31 +0200 Subject: [PATCH] Fix return value of attr_name_val_split() and attr_op()
this patch also fix gcc warnings
I guess you mean the patch you forget to attach? :-)
src/tools/sss_sync_ops.c:94: warning: 'name' may be used uninitialized in this function src/tools/sss_sync_ops.c:95: warning: 'vals' may be used uninitialized in this function src/tools/sss_sync_ops.c:96: warning: 'nvals' may be used uninitialized in this function
ACK
LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On (12/06/14 15:33), Pavel Reichl wrote:
On Thu, 2014-06-12 at 15:15 +0200, Lukas Slebodnik wrote:
On (12/06/14 10:31), Sumit Bose wrote:
On Thu, Jun 12, 2014 at 09:21:55AM +0200, Lukas Slebodnik wrote:
On (11/06/14 20:54), Sumit Bose wrote:
Hi,
I found this wrong return value. I've checked the other recent posting and didn't found a patch for this. If someone already send a patch for this please point me to the right thread so that I can ack it.
bye, Sumit
From 9c3d4f637d80448922779b093fc4a2da909054e4 Mon Sep 17 00:00:00 2001 From: Sumit Bose sbose@redhat.com Date: Wed, 11 Jun 2014 20:49:31 +0200 Subject: [PATCH] Fix return value of attr_name_val_split()
src/tools/sss_sync_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tools/sss_sync_ops.c b/src/tools/sss_sync_ops.c index 232a711..667c8a6 100644 --- a/src/tools/sss_sync_ops.c +++ b/src/tools/sss_sync_ops.c @@ -83,7 +83,7 @@ static int attr_name_val_split(TALLOC_CTX *mem_ctx, const char *nameval, ret = EOK; done: talloc_free(tmp_ctx);
- return EOK;
- return ret;
ACK, but could you also change the same problem in "static int attr_op" (the same file).
Thank you, good catch, new version attached.
bye, Sumit
From 1bcb5a8a6e9d4c032d5599ee900002a863ae8a4a Mon Sep 17 00:00:00 2001 From: Sumit Bose sbose@redhat.com Date: Wed, 11 Jun 2014 20:49:31 +0200 Subject: [PATCH] Fix return value of attr_name_val_split() and attr_op()
this patch also fix gcc warnings
I guess you mean the patch you forget to attach? :-)
No, I meant Sumit's patch.
LS
On Thu, Jun 12, 2014 at 03:15:14PM +0200, Lukas Slebodnik wrote:
this patch also fix gcc warnings src/tools/sss_sync_ops.c:94: warning: 'name' may be used uninitialized in this function src/tools/sss_sync_ops.c:95: warning: 'vals' may be used uninitialized in this function src/tools/sss_sync_ops.c:96: warning: 'nvals' may be used uninitialized in this function
ACK
LS
Pushed to master: c9f94bc64ed7dfbaef5a520bfc4e911c5d0ad6fe
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Lukas Slebodnik -
Pavel Reichl -
Sumit Bose